New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUID validation on jobref #4366

Merged
merged 3 commits into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@jtobard
Copy link
Contributor

jtobard commented Jan 8, 2019

fix #4337
New error message when the job name and the UUID of the job don't match, preventing users to enter a wrong UUID and rely on the job name field.

As always users can delete the UUID and reference jobs only using the jobname or delete the jobname and use only the UUID. But if both fields are filled they must correspond to the same job.
screenshot

fix #4337 new error message when the jobname and the uuid of the job …
…doesnt match, preventing users to enter a wrong uuid and rely on the job name field.

@jtobard jtobard added this to the 3.0.12 milestone Jan 8, 2019

@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Jan 8, 2019

Perhaps the job ref input, or the error message, should explain it as you just did "You can enter a job name or UUID, but if both UUID and job name are specified they must correspond to the same job"

@jtobard

This comment has been minimized.

Copy link
Contributor Author

jtobard commented Jan 8, 2019

imagen

@gschueler gschueler merged commit a5f8130 into master Jan 22, 2019

20 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment