New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI plugin install status fix #4379

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
2 participants
@sjrd218
Copy link
Contributor

sjrd218 commented Jan 11, 2019

Fix a bug when a UI plugin is installed it is not flagged as installed when listing repository plugins.

@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Jan 14, 2019

any reason not to just include the UI plugins in the "listPluginsDetailed()" results?

@sjrd218

This comment has been minimized.

Copy link
Contributor Author

sjrd218 commented Jan 14, 2019

If we add UI plugins to the output of listPluginDetailed() they would show up on the list plugins UI. That list did not previously include UI plugins. Since I didn't know the reasoning behind leaving them out, I opted for the more conservative approach of keeping it the same.

@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Jan 16, 2019

ok we can revisit it later

@gschueler gschueler added this to the 3.0.13 milestone Jan 16, 2019

@gschueler gschueler merged commit eeaeb33 into master Jan 16, 2019

20 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment