Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Plugin provider metadata #4393

Merged
merged 28 commits into from Feb 15, 2019

Conversation

@gschueler
Copy link
Member

commented Jan 17, 2019

Is this a bugfix, or an enhancement? Please describe.

Enables plugin providers to define a map of metadata key/values.
This can be used to support simple plugin icons using glyphicons/font-awesome, as well as other use cases.

The metadata can be defined for java, script, or groovy plugins

Describe the solution you've implemented

For Java; add new annotation types
For script: support new plugin-meta yaml entry
For groovy; support metadata map property inside plugin DSL

For front-end: include provider metadata in provider description responses for plugin detail and provider descriptions list endpoints

TBD

  • add docs
  • support Log Filter plugins GUI display with new icons
  • fix issue with NodeStepPlugin vs. RemoteScriptNodeStepPlugin loading
@gschueler

This comment has been minimized.

Copy link
Member Author

commented Jan 18, 2019

added docs rundeck/docs#202

gschueler added some commits Jan 17, 2019

Script plugins: providers can define metadata
via 'plugin-meta' entry in plugin.yaml

@gschueler gschueler force-pushed the feature/plugin-provider-metadata branch from 2943c51 to c2d6299 Jan 23, 2019

@gschueler gschueler removed this from the 3.0.13 milestone Jan 23, 2019

@gschueler

This comment has been minimized.

Copy link
Member Author

commented Jan 25, 2019

  • support Log Filter plugins GUI display with new icons
  • fix issue with NodeStepPlugin vs. RemoteScriptNodeStepPlugin loading

gschueler added some commits Jan 25, 2019

@sjrd218
Copy link
Contributor

left a comment

This is fixed.

@gschueler gschueler added this to the 3.0.14 milestone Jan 30, 2019

gschueler added some commits Feb 8, 2019

Merge branch 'feature/plugin-provider-metadata' of github.com:rundeck…
…/rundeck into feature/plugin-provider-metadata
Enable font-awesome brand icons using `fabicon`
metadata key for provider: `fabicon`

@gschueler gschueler merged commit 6798425 into master Feb 15, 2019

21 checks passed

Mergeable Mergeable Run have been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.