Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job detail in execution xml for log storage #4431

Merged
merged 3 commits into from Feb 6, 2019

Conversation

@jtobard
Copy link
Contributor

commented Jan 28, 2019

fix #4414
Adds the full job in the current state to the execution XML exported. So, if you go through the files in alphabetical order you can get a list of job's definition to recreate them.

jtobard added some commits Jan 28, 2019

@gschueler gschueler self-requested a review Jan 30, 2019

@gschueler
Copy link
Member

left a comment

The XML generation of execution.xml should not be duplicated from project service: perhaps it should be moved into ExecutionUtilService where it kind of makes more sense anyway.

this should be an optional feature enabled by a flag somehow (and perhaps disabled by default)

@jtobard

This comment has been minimized.

Copy link
Contributor Author

commented Feb 6, 2019

Disabled by default, can be enabled adding rundeck.backup.jobs.enabled=true to rundeck-config.properties

@gschueler gschueler added this to the 3.0.14 milestone Feb 6, 2019

@gschueler gschueler merged commit 4a64c16 into master Feb 6, 2019

21 checks passed

Mergeable Mergeable Run have been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@jtobard jtobard deleted the issue/4414 branch Feb 18, 2019

@ahonor

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Rename the feature flag to rundeck.execution.logs.fileStorage.generateExecutionXml.
The execution.xml file should use naming convention "{id}.execution.xml".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.