Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tomcat api tests #4433

Merged
merged 2 commits into from Feb 21, 2019

Conversation

@ProTip
Copy link
Contributor

commented Jan 29, 2019

Builds a custom test container off the tomcat:8 docker image and runs the api test suite against it.

@ProTip ProTip force-pushed the tomcat-test branch 3 times, most recently from cdb21b7 to 088d6bf Jan 29, 2019

@gschueler gschueler self-requested a review Jan 30, 2019

@gschueler
Copy link
Member

left a comment

this dir test/docker/dockers/tomcat/api_test/ seems to contain duplicates of some of the test/api dir, can those files be copied into the docker image from the original location instead of duplicated?

@gschueler

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

ping @ProTip

@ProTip

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

@gschueler Good catch; I mistook the source of those files as another location(that they get copied to) and thought I was avoiding intertwining the builds.

@gschueler

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

travis error:


Waiting for  to start... 
starting test.sh
chmod: cannot access '/api_test/src/test.sh': No such file or directory
http://127.0.0.1:8080/rundeck: /api_test/src/test.sh: No such file or directory
test.sh finished with 127
run_tests.sh finished with: 127
Attaching to docker_rundeck1_1

@ProTip ProTip force-pushed the tomcat-test branch from 99cdf0b to f8ec795 Feb 20, 2019

@ProTip ProTip force-pushed the tomcat-test branch from f8ec795 to 146ea55 Feb 21, 2019

@ProTip ProTip added this to the 3.0.14 milestone Feb 21, 2019

@ProTip ProTip merged commit b1fda91 into master Feb 21, 2019

19 of 20 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Mergeable Mergeable Run has been Completed!
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.