Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/version notification #4460

Merged
merged 3 commits into from Feb 6, 2019

Conversation

@jessemarple
Copy link
Contributor

commented Feb 5, 2019

Adds a non-intrusive Update Available notification in the left sidebar and an accompanying modal that includes information about current release available, release date, and installed version. Offers ability to dismiss notification until next release.

@jessemarple jessemarple added this to the 3.0.14 milestone Feb 5, 2019

@jessemarple jessemarple self-assigned this Feb 5, 2019

@jessemarple jessemarple added this to In progress in Rundeck UI 3.0.x via automation Feb 5, 2019

@jessemarple jessemarple requested a review from ProTip Feb 5, 2019

@ProTip

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

We may need to update the CSP connect-src default to allow api.rundeck.com(or *.rundeck.com if we don't mind being responsible for that).

@ProTip
Copy link
Contributor

left a comment

I've build this under a different version to trigger the notification, however I'm seeing this error in the console:
image

I have verified the API response is returning with the version info..

@ProTip ProTip force-pushed the feature/version-notification branch from 1ba5053 to 3018977 Feb 6, 2019

@ProTip ProTip force-pushed the feature/version-notification branch from b3550e4 to 653c907 Feb 6, 2019

@gschueler
Copy link
Member

left a comment

if the project-jobs is not meant to be part of this pr, please remove it

Show resolved Hide resolved rundeckapp/grails-app/views/menu/jobs.gsp Outdated

Rundeck UI 3.0.x automation moved this from In progress to Testing Feb 6, 2019

@ProTip ProTip force-pushed the feature/version-notification branch from 64d89d7 to deaa80e Feb 6, 2019

@ProTip ProTip merged commit 2a8d67b into master Feb 6, 2019

21 checks passed

Mergeable Mergeable Run have been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

Rundeck UI 3.0.x automation moved this from Testing to Done Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.