From 93150f8bc02335e2194731f5f879002f1318c247 Mon Sep 17 00:00:00 2001
From: carlos <carloseduardo.rorizfranco@gmail.com>
Date: Fri, 8 Feb 2019 09:26:33 -0200
Subject: [PATCH 1/5] Job options may be hidden from job run page

---
 .../assets/javascripts/menu/joboptions.js     |  1 +
 .../grails-app/domain/rundeck/Option.groovy   | 12 +++-
 .../grails-app/i18n/messages.properties       |  2 +
 .../views/framework/_jobOptionsKO.gsp         | 66 ++++++++++---------
 .../views/scheduledExecution/_optEdit.gsp     | 20 ++++++
 5 files changed, 68 insertions(+), 33 deletions(-)

diff --git a/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js b/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js
index b98c2bb500c..f5360565155 100644
--- a/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js
+++ b/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js
@@ -58,6 +58,7 @@ function Option(data) {
     self.descriptionHtml = ko.observable(data.descriptionHtml);
     self.loading = ko.observable(false);
     self.required = ko.observable(data.required ? true : false);
+    self.shouldBeHidden = ko.observable(data.shouldBeHidden ? true : false);
     self.enforced = ko.observable(data.enforced ? true : false);
     self.isDate = ko.observable(data.isDate ? true : false);
     self.dateFormat = ko.observable(data.dateFormat);
diff --git a/rundeckapp/grails-app/domain/rundeck/Option.groovy b/rundeckapp/grails-app/domain/rundeck/Option.groovy
index 0050637c287..37776f89f46 100644
--- a/rundeckapp/grails-app/domain/rundeck/Option.groovy
+++ b/rundeckapp/grails-app/domain/rundeck/Option.groovy
@@ -71,6 +71,7 @@ public class Option implements Comparable{
     Boolean multivalueAllSelected
     String optionValuesPluginType
     List<OptionValue> valuesFromPlugin
+    Boolean shouldBeHidden
 
     static belongsTo=[scheduledExecution:ScheduledExecution]
     static transients = ['valuesList', 'realValuesUrl', 'configMap', 'typeFile','valuesFromPlugin']
@@ -99,6 +100,7 @@ public class Option implements Comparable{
         multivalueAllSelected(nullable: true)
         label(nullable: true)
         optionValuesPluginType(nullable: true)
+        shouldBeHidden(nullable: true)
     }
 
 
@@ -198,6 +200,9 @@ public class Option implements Comparable{
         if(optionValuesPluginType) {
             map.optionValuesPluginType = optionValuesPluginType
         }
+        if(shouldBeHidden){
+            map.shouldBeHidden = shouldBeHidden
+        }
         return map
     }
 
@@ -261,6 +266,9 @@ public class Option implements Comparable{
         if(data.optionValuesPluginType) {
             opt.optionValuesPluginType = data.optionValuesPluginType
         }
+        if(data.shouldBeHidden){
+            opt.shouldBeHidden = data.shouldBeHidden
+        }
         return opt
     }
     /**
@@ -349,7 +357,7 @@ public class Option implements Comparable{
          'dateFormat', 'values', 'valuesList', 'valuesUrl', 'valuesUrlLong', 'regex', 'multivalued',
          'multivalueAllSelected', 'label',
          'delimiter', 'optionValuesPluginType',
-         'secureInput', 'secureExposed', 'optionType', 'configData'].
+         'secureInput', 'secureExposed', 'optionType', 'configData', 'shouldBeHidden'].
                 each { k ->
             opt[k]=this[k]
         }
@@ -381,7 +389,7 @@ public class Option implements Comparable{
                ', optionValuesPluginType=' + optionValuesPluginType + '\'' +
                 ", optionType='" + optionType + '\'' +
                 ", configData='" + configData + '\'' +
-
+        ", shouldBeHidden='" + '\'' +
         '}' ;
     }
 
diff --git a/rundeckapp/grails-app/i18n/messages.properties b/rundeckapp/grails-app/i18n/messages.properties
index 323cbff2509..0176bcb94c4 100644
--- a/rundeckapp/grails-app/i18n/messages.properties
+++ b/rundeckapp/grails-app/i18n/messages.properties
@@ -570,6 +570,8 @@ select.jobs.to.delete=Select Jobs to delete.
 project.name.can.only.contain.these.characters=Project name can only contain these characters\: [a-zA-Z0-9_-+.] and cannot start with a '.'.
 Option.required.label=Required
 Option.required.description=Require this option to have a non-blank value when running the Job
+Option.hidden.label=Should be hidden
+Option.hidden.description=Should be hidden from job run page
 execution=Execution
 plural.format={1}
 plural.count.format={0} {1}
diff --git a/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp b/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
index a1cdd0c910e..e56748a8dbf 100644
--- a/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
+++ b/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
@@ -84,6 +84,8 @@ used by _editOptions.gsp template
                                                               selectedoptsmap[optName] :
                                                               (optionSelect.defaultValue ?: ''),
                                               valuesFromPlugin   : optionSelect.valuesFromPlugin
+                                                              (optionSelect.defaultValue ?: ''),
+                                              shouldBeHidden     : !!optionSelect.shouldBeHidden
                                       ]
                                   }
     ]}" id="jobOptionData"/>
@@ -102,48 +104,50 @@ data for configuring remote option cascading/dependencies
     </g:if>
 
     <div id="_commandOptions" data-bind="foreach: {data: options(), as: 'option' }">
-        <div class="form-group " data-bind="
+        <div data-bind="visible: !shouldBeHidden()">
+            <div class="form-group " data-bind="
     css: { 'has-warning': hasError, 'remote': hasRemote }
     ">
-            <label class="remoteoptionfield col-sm-2 control-label"
-                   data-bind="attr: { for: fieldId }, click: reloadRemoteValues">
-                <span data-bind="if: hasRemote()">
-                    <span data-bind="if: loading() ">
-                        <g:img class="loading-spinner" file="spinner-gray.gif" width="16px" height="16px"/>
+                <label class="remoteoptionfield col-sm-2 control-label"
+                       data-bind="attr: { for: fieldId }, click: reloadRemoteValues">
+                    <span data-bind="if: hasRemote()">
+                        <span data-bind="if: loading() ">
+                            <g:img class="loading-spinner" file="spinner-gray.gif" width="16px" height="16px"/>
+                        </span>
+                        <span class="remotestatus"
+                              data-bind=" css: {ok: !remoteError() && remoteValues().length>0 && remoteValues, error: remoteError()}">
+                        </span>
+                        <span data-bind="text: name"></span>
                     </span>
-                    <span class="remotestatus"
-                          data-bind=" css: {ok: !remoteError() && remoteValues().length>0 && remoteValues, error: remoteError()}">
+                    <span data-bind="if: !hasRemote()">
+                        <span data-bind="text: label"></span>
                     </span>
-                    <span data-bind="text: name"></span>
-                </span>
-                <span data-bind="if: !hasRemote()">
-                    <span data-bind="text: label"></span>
-                </span>
-            </label>
+                </label>
 
-            <div class=" col-sm-9">
+                <div class=" col-sm-9">
 
-                <g:render template="/framework/optionValuesSelectKO"/>
+                    <g:render template="/framework/optionValuesSelectKO"/>
 
-            </div>
+                </div>
 
-            <div class="col-sm-1">
-                <span data-bind="if: required">
-                    <span class="reqwarning has_tooltip"
-                          data-bind="attr: {title: hasError()||message('option.value.required') }, visible: !hasValue(), bootstrapTooltip: true"
-                          data-toggle="tooltip">
-                        <i class="glyphicon glyphicon-warning-sign"></i>
+                <div class="col-sm-1">
+                    <span data-bind="if: required">
+                        <span class="reqwarning has_tooltip"
+                              data-bind="attr: {title: hasError()||message('option.value.required') }, visible: !hasValue(), bootstrapTooltip: true"
+                              data-toggle="tooltip">
+                            <i class="glyphicon glyphicon-warning-sign"></i>
+                        </span>
                     </span>
-                </span>
-            </div>
+                </div>
 
-            <div class="col-sm-10 col-sm-offset-2">
-                %{--<span class="help-block" data-bind="text: description"></span>--}%
-                <span class="help-block" data-bind="html: descriptionHtml"></span>
-            </div>
+                <div class="col-sm-10 col-sm-offset-2">
+                    %{--<span class="help-block" data-bind="text: description"></span>--}%
+                    <span class="help-block" data-bind="html: descriptionHtml"></span>
+                </div>
 
-            <div class="col-sm-10 col-sm-offset-2" data-bind="if: hasError">
-                <p class="text-warning" data-bind="text: hasError"></p>
+                <div class="col-sm-10 col-sm-offset-2" data-bind="if: hasError">
+                    <p class="text-warning" data-bind="text: hasError"></p>
+                </div>
             </div>
         </div>
     </div>
diff --git a/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp b/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp
index e8ecaa36c6f..6728f0f550b 100644
--- a/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp
+++ b/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp
@@ -536,6 +536,26 @@
                 </div>
             </div>
         </div>
+        <div class="form-group">
+            <label class="col-sm-2 control-label"><g:message code="Option.hidden.label" /></label>
+            <div class="col-sm-10">
+                <div class="radio radio-inline">
+                    <g:radio id="option-hidden-no" name="shouldBeHidden" value="false" checked="${!option || !option.shouldBeHidden}"/>
+                    <label for="option-hidden-no">
+                        <g:message code="no" />
+                    </label>    
+                </div>
+                <div class="radio radio-inline">
+                    <g:radio id="option-hidden-yes" name="shouldBeHidden" value="true" checked="${option?.shouldBeHidden}"/>
+                    <label for="option-hidden-yes">
+                        <g:message code="yes" />
+                    </label>
+                </div>
+                <div class="help-block">
+                    <g:message code="Option.hidden.description"/>
+                </div>
+            </div>
+        </div>
         <!-- ko if: !isFileType() -->
         <div class="form-group">
             <label class="col-sm-2 control-label ${hasErrors(bean: option, field: 'multivalued', 'has-error')}">

From ae9c20f4cdfe1ce15fe0f3d46a38a0af4b1f89d9 Mon Sep 17 00:00:00 2001
From: carlos <carloseduardo.rorizfranco@gmail.com>
Date: Fri, 8 Feb 2019 10:09:43 -0200
Subject: [PATCH 2/5] Fixing incorrect merge

---
 rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp b/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
index e56748a8dbf..2778095acc3 100644
--- a/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
+++ b/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
@@ -83,8 +83,7 @@ used by _editOptions.gsp template
                                                       selectedoptsmap && null != selectedoptsmap[optName] ?
                                                               selectedoptsmap[optName] :
                                                               (optionSelect.defaultValue ?: ''),
-                                              valuesFromPlugin   : optionSelect.valuesFromPlugin
-                                                              (optionSelect.defaultValue ?: ''),
+                                              valuesFromPlugin   : optionSelect.valuesFromPlugin,
                                               shouldBeHidden     : !!optionSelect.shouldBeHidden
                                       ]
                                   }

From cf1038b40262df4e46c86026ae46a69eba3fb0a2 Mon Sep 17 00:00:00 2001
From: carlos <carloseduardo.rorizfranco@gmail.com>
Date: Fri, 8 Feb 2019 19:09:19 -0200
Subject: [PATCH 3/5] Job options may be hidden from job run page

---
 .../rundeck/controllers/EditOptsController.groovy      | 10 ++++++++--
 rundeckapp/grails-app/i18n/messages.properties         |  1 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy b/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy
index 3f0d8182a3f..e018345b7e7 100644
--- a/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy
+++ b/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy
@@ -16,11 +16,12 @@
 
 package rundeck.controllers
 
-import java.util.regex.Pattern
-import java.util.regex.PatternSyntaxException
 import rundeck.Option
 import rundeck.ScheduledExecution
 
+import java.util.regex.Pattern
+import java.util.regex.PatternSyntaxException
+
 /**
  * Controller for manipulating the session-stored set of Options during job edit
  */
@@ -498,6 +499,11 @@ class EditOptsController {
             opt.errors.rejectValue('required', 'option.file.required.message')
             return result
         }
+
+        if (opt.shouldBeHidden && !opt.defaultValue && !opt.defaultStoragePath) {
+            opt.errors.rejectValue('shouldBeHidden', 'option.shouldbehidden.notallowed.message')
+            return result
+        }
         if (opt.enforced && (opt.values || opt.valuesList) && opt.defaultValue) {
             opt.convertValuesList()
             if(!opt.multivalued && !opt.values.contains(opt.defaultValue)) {
diff --git a/rundeckapp/grails-app/i18n/messages.properties b/rundeckapp/grails-app/i18n/messages.properties
index 0176bcb94c4..058b3b8ac7d 100644
--- a/rundeckapp/grails-app/i18n/messages.properties
+++ b/rundeckapp/grails-app/i18n/messages.properties
@@ -175,6 +175,7 @@ option.defaultValue.notallowed.message=Default Value was not in the allowed valu
 option.defaultValue.multivalued.notallowed.message=Default Value contains a string that was not in the allowed values list, and values are enforced: "{0}". Note: whitespace is significant.
 option.defaultValue.required.message=Specify a Default Value for Required options when the Job is scheduled.
 option.file.required.message=File option type cannot be Required when the Job is scheduled.
+option.shouldbehidden.notallowed.message=Hidden options must have a default value.
 option.file.config.invalid.message=File option type config is not valid: {0}
 option.regex.invalid.message=Invalid Regular Expression: {0}
 option.values.regexmismatch.message=Allowed value "{0}" does not match the regex: {1}

From 402e586f376d42faff3f7cc151d89f7501b55ee4 Mon Sep 17 00:00:00 2001
From: carlos <carloseduardo.rorizfranco@gmail.com>
Date: Mon, 18 Feb 2019 10:01:23 -0300
Subject: [PATCH 4/5] Changing label "Should be hidden" to "Hidden"

---
 rundeckapp/grails-app/i18n/messages.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rundeckapp/grails-app/i18n/messages.properties b/rundeckapp/grails-app/i18n/messages.properties
index 058b3b8ac7d..3da6c1ecb55 100644
--- a/rundeckapp/grails-app/i18n/messages.properties
+++ b/rundeckapp/grails-app/i18n/messages.properties
@@ -571,7 +571,7 @@ select.jobs.to.delete=Select Jobs to delete.
 project.name.can.only.contain.these.characters=Project name can only contain these characters\: [a-zA-Z0-9_-+.] and cannot start with a '.'.
 Option.required.label=Required
 Option.required.description=Require this option to have a non-blank value when running the Job
-Option.hidden.label=Should be hidden
+Option.hidden.label=Hidden
 Option.hidden.description=Should be hidden from job run page
 execution=Execution
 plural.format={1}

From 29e0ea0ee46acd062ad186ab56f70121898a2bb4 Mon Sep 17 00:00:00 2001
From: carlos <carloseduardo.rorizfranco@gmail.com>
Date: Mon, 18 Feb 2019 10:36:14 -0300
Subject: [PATCH 5/5] Changing names of the boolean flags from "shouldBeHidden"
 to "hidden"

---
 .../assets/javascripts/menu/joboptions.js        |  2 +-
 .../controllers/EditOptsController.groovy        |  4 ++--
 .../grails-app/domain/rundeck/Option.groovy      | 16 ++++++++--------
 rundeckapp/grails-app/i18n/messages.properties   |  4 ++--
 .../grails-app/views/framework/_jobOptionsKO.gsp |  4 ++--
 .../views/scheduledExecution/_optEdit.gsp        |  4 ++--
 6 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js b/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js
index f5360565155..8fc41f80d83 100644
--- a/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js
+++ b/rundeckapp/grails-app/assets/javascripts/menu/joboptions.js
@@ -58,7 +58,7 @@ function Option(data) {
     self.descriptionHtml = ko.observable(data.descriptionHtml);
     self.loading = ko.observable(false);
     self.required = ko.observable(data.required ? true : false);
-    self.shouldBeHidden = ko.observable(data.shouldBeHidden ? true : false);
+    self.hidden = ko.observable(data.hidden ? true : false);
     self.enforced = ko.observable(data.enforced ? true : false);
     self.isDate = ko.observable(data.isDate ? true : false);
     self.dateFormat = ko.observable(data.dateFormat);
diff --git a/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy b/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy
index e018345b7e7..1301ca2278f 100644
--- a/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy
+++ b/rundeckapp/grails-app/controllers/rundeck/controllers/EditOptsController.groovy
@@ -500,8 +500,8 @@ class EditOptsController {
             return result
         }
 
-        if (opt.shouldBeHidden && !opt.defaultValue && !opt.defaultStoragePath) {
-            opt.errors.rejectValue('shouldBeHidden', 'option.shouldbehidden.notallowed.message')
+        if (opt.hidden && !opt.defaultValue && !opt.defaultStoragePath) {
+            opt.errors.rejectValue('hidden', 'option.hidden.notallowed.message')
             return result
         }
         if (opt.enforced && (opt.values || opt.valuesList) && opt.defaultValue) {
diff --git a/rundeckapp/grails-app/domain/rundeck/Option.groovy b/rundeckapp/grails-app/domain/rundeck/Option.groovy
index 37776f89f46..4c0cfa7ffe6 100644
--- a/rundeckapp/grails-app/domain/rundeck/Option.groovy
+++ b/rundeckapp/grails-app/domain/rundeck/Option.groovy
@@ -71,7 +71,7 @@ public class Option implements Comparable{
     Boolean multivalueAllSelected
     String optionValuesPluginType
     List<OptionValue> valuesFromPlugin
-    Boolean shouldBeHidden
+    Boolean hidden
 
     static belongsTo=[scheduledExecution:ScheduledExecution]
     static transients = ['valuesList', 'realValuesUrl', 'configMap', 'typeFile','valuesFromPlugin']
@@ -100,7 +100,7 @@ public class Option implements Comparable{
         multivalueAllSelected(nullable: true)
         label(nullable: true)
         optionValuesPluginType(nullable: true)
-        shouldBeHidden(nullable: true)
+        hidden(nullable: true)
     }
 
 
@@ -200,8 +200,8 @@ public class Option implements Comparable{
         if(optionValuesPluginType) {
             map.optionValuesPluginType = optionValuesPluginType
         }
-        if(shouldBeHidden){
-            map.shouldBeHidden = shouldBeHidden
+        if(hidden){
+            map.hidden = hidden
         }
         return map
     }
@@ -266,8 +266,8 @@ public class Option implements Comparable{
         if(data.optionValuesPluginType) {
             opt.optionValuesPluginType = data.optionValuesPluginType
         }
-        if(data.shouldBeHidden){
-            opt.shouldBeHidden = data.shouldBeHidden
+        if(data.hidden){
+            opt.hidden = data.hidden
         }
         return opt
     }
@@ -357,7 +357,7 @@ public class Option implements Comparable{
          'dateFormat', 'values', 'valuesList', 'valuesUrl', 'valuesUrlLong', 'regex', 'multivalued',
          'multivalueAllSelected', 'label',
          'delimiter', 'optionValuesPluginType',
-         'secureInput', 'secureExposed', 'optionType', 'configData', 'shouldBeHidden'].
+         'secureInput', 'secureExposed', 'optionType', 'configData', 'hidden'].
                 each { k ->
             opt[k]=this[k]
         }
@@ -389,7 +389,7 @@ public class Option implements Comparable{
                ', optionValuesPluginType=' + optionValuesPluginType + '\'' +
                 ", optionType='" + optionType + '\'' +
                 ", configData='" + configData + '\'' +
-        ", shouldBeHidden='" + '\'' +
+        ", hidden='" + '\'' +
         '}' ;
     }
 
diff --git a/rundeckapp/grails-app/i18n/messages.properties b/rundeckapp/grails-app/i18n/messages.properties
index 3da6c1ecb55..d2cba74b4ab 100644
--- a/rundeckapp/grails-app/i18n/messages.properties
+++ b/rundeckapp/grails-app/i18n/messages.properties
@@ -175,7 +175,7 @@ option.defaultValue.notallowed.message=Default Value was not in the allowed valu
 option.defaultValue.multivalued.notallowed.message=Default Value contains a string that was not in the allowed values list, and values are enforced: "{0}". Note: whitespace is significant.
 option.defaultValue.required.message=Specify a Default Value for Required options when the Job is scheduled.
 option.file.required.message=File option type cannot be Required when the Job is scheduled.
-option.shouldbehidden.notallowed.message=Hidden options must have a default value.
+option.hidden.notallowed.message=Hidden options must have a default value.
 option.file.config.invalid.message=File option type config is not valid: {0}
 option.regex.invalid.message=Invalid Regular Expression: {0}
 option.values.regexmismatch.message=Allowed value "{0}" does not match the regex: {1}
@@ -571,7 +571,7 @@ select.jobs.to.delete=Select Jobs to delete.
 project.name.can.only.contain.these.characters=Project name can only contain these characters\: [a-zA-Z0-9_-+.] and cannot start with a '.'.
 Option.required.label=Required
 Option.required.description=Require this option to have a non-blank value when running the Job
-Option.hidden.label=Hidden
+Option.hidden.label=Should be hidden
 Option.hidden.description=Should be hidden from job run page
 execution=Execution
 plural.format={1}
diff --git a/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp b/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
index 2778095acc3..de73c8d39b2 100644
--- a/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
+++ b/rundeckapp/grails-app/views/framework/_jobOptionsKO.gsp
@@ -84,7 +84,7 @@ used by _editOptions.gsp template
                                                               selectedoptsmap[optName] :
                                                               (optionSelect.defaultValue ?: ''),
                                               valuesFromPlugin   : optionSelect.valuesFromPlugin,
-                                              shouldBeHidden     : !!optionSelect.shouldBeHidden
+                                              hidden     : !!optionSelect.hidden
                                       ]
                                   }
     ]}" id="jobOptionData"/>
@@ -103,7 +103,7 @@ data for configuring remote option cascading/dependencies
     </g:if>
 
     <div id="_commandOptions" data-bind="foreach: {data: options(), as: 'option' }">
-        <div data-bind="visible: !shouldBeHidden()">
+        <div data-bind="visible: !hidden()">
             <div class="form-group " data-bind="
     css: { 'has-warning': hasError, 'remote': hasRemote }
     ">
diff --git a/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp b/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp
index 6728f0f550b..091b094c93b 100644
--- a/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp
+++ b/rundeckapp/grails-app/views/scheduledExecution/_optEdit.gsp
@@ -540,13 +540,13 @@
             <label class="col-sm-2 control-label"><g:message code="Option.hidden.label" /></label>
             <div class="col-sm-10">
                 <div class="radio radio-inline">
-                    <g:radio id="option-hidden-no" name="shouldBeHidden" value="false" checked="${!option || !option.shouldBeHidden}"/>
+                    <g:radio id="option-hidden-no" name="hidden" value="false" checked="${!option || !option.hidden}"/>
                     <label for="option-hidden-no">
                         <g:message code="no" />
                     </label>    
                 </div>
                 <div class="radio radio-inline">
-                    <g:radio id="option-hidden-yes" name="shouldBeHidden" value="true" checked="${option?.shouldBeHidden}"/>
+                    <g:radio id="option-hidden-yes" name="hidden" value="true" checked="${option?.hidden}"/>
                     <label for="option-hidden-yes">
                         <g:message code="yes" />
                     </label>