Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scheduled execution stats table #4482

Merged
merged 2 commits into from Feb 21, 2019

Conversation

@jtobard
Copy link
Contributor

commented Feb 11, 2019

New domain table ScheduledExecutionStats to use instead of ScheduledExecution on statistics.

The objective of this change is to reduce the direct use of the ScheduledExecution table at updating or consulting the average time statistics.

Reduces the appearance of deadlocks by updating the statistics in the referenced jobs.

Docker test included to detect the appearance of deadlocks on parallel usage of the table:
test/api/test-job-run-without-deadlock.sh

New jobs will be created with a field on the ScheduledExecutionStats table and existing fields will be migrated in usage or retrieve of the data.

@gschueler
Copy link
Member

left a comment

The ScheduledExecutionStats.groovy could be changed:

  • use json blob data instead of explicit fields for stats data
  • no need for explicit scheduledExecutionId field to reference the related ScheduledExecution domain class

@jtobard jtobard added this to the 3.0.14 milestone Feb 21, 2019

@gschueler gschueler merged commit 1e6bab0 into master Feb 21, 2019

21 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@jtobard jtobard deleted the feature/scheduled-execution-stats-rebase branch Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.