Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/community news component #4485

Merged
merged 37 commits into from Feb 19, 2019

Conversation

@jessemarple
Copy link
Contributor

commented Feb 12, 2019

Introduces the Community News page/component.

Component adds a sidebar item (sidebar was also slightly refactored to account for this) that displays the community news indicator. It checks the existence/value of a cookie and proceeds to badge new items if conditions are met. Component is a link to the Community News page.

The Community News page is a static page (Controller, Action, URL handling) that loads a Vue application which connects to Hubspot for Community News. It sets a cookie that has a 7 day expiration with the idea being that once you've read the news, we probably won't publish anything again that needs badging for a week.

Updates were made to the sidebar in support of both Community News and Version Notification.

ProTip and others added some commits Nov 5, 2018

@jessemarple jessemarple added this to the 3.0.14 milestone Feb 12, 2019

@jessemarple jessemarple self-assigned this Feb 12, 2019

@jessemarple jessemarple requested a review from sjrd218 Feb 12, 2019

@ProTip

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

@jessemarple It might be worth Cherry picking the news commits onto a branch based off master. That should get rid of all the un-squashed commits from previous branches.

sjrd218 and others added some commits Feb 13, 2019

Removes aligators that were hanging out in the jobs.gsp
The Jobs gsp had an Vue app that isnt' ready for prime time referenced in the footer. Removed and apparently had a merge conflict that left an artifact.
methods: {
handleSubmit() {
axios
.post("https://api-stage.rundeck.com/spark/v1/subscribe", {

This comment has been minimized.

Copy link
@ProTip

ProTip Feb 14, 2019

Contributor

I believe this should point api.rundeck.com. @sjrd218 We may move this to another endpoint?

This comment has been minimized.

Copy link
@sjrd218

sjrd218 Feb 14, 2019

Contributor

Eventually it should point to api.rundeck.com/online/v1/subscribe but that path change hasn't been made yet, so I figured this would be fine for now until we get it updated.

@gschueler gschueler merged commit ef1817e into master Feb 19, 2019

21 checks passed

Mergeable Mergeable Run have been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.