Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed UUID validation of jobRef #4516

Merged
merged 5 commits into from Feb 21, 2019

Conversation

@jtobard
Copy link
Contributor

commented Feb 18, 2019

Job reference step using UUID and job name pointing to a job that doesn't exist won't fail it will only remove the UUID component and leave just the jobname reference.

Fix #4451 and 4471

fix #4471 jobref using uuid and job name pointing to a job that does …
…not exist wont fail ot only remove the uuid component and leave just the jobname reference

@jtobard jtobard added this to the 3.0.14 milestone Feb 19, 2019

@ProTip

This comment has been minimized.

Copy link
Contributor

commented Feb 19, 2019

@jtobard are you able to import the archive from #4451 ? I seem to be unable to import it on anything above 3.0.12, including a build of this branch.. It's odd because the job name and UUID match the referenced job in that archive..

@jtobard

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

@ProTip my mistake, missing some code on the PR maybe because I moved from another branch by hand, now pushing it.

@gschueler

This comment has been minimized.

Copy link
Member

commented Feb 19, 2019

@jtobard perhaps there needs to be a functional test performing the import

@ProTip

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

@jtobard Thanks! I have tested this and it does let me import the project, as well as the project if a referenced job has been renamed.

It seems though that the Job names are getting stripped(instead of just ignored for validation purposes). After I import the example project where everything matches, and I view the reference workflow step, only the UUID remains in GUI. Without looking up the name and displaying it users may be surprised that the reference names are gone after an import?

I'm also curious that in the case of #4471 if we strip the UUID when importing jobs out of order, will this leave only the job name? In that case if a job has been renamed or regrouped the UUID may actually be correct and leaving just the name as reference may break the workflows.

jtobard added a commit that referenced this pull request Feb 21, 2019

@gschueler gschueler merged commit e40fec2 into master Feb 21, 2019

21 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@gschueler gschueler deleted the issue/4471 branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.