Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use master branch of ui trellis #4555

Merged
merged 2 commits into from Mar 8, 2019

Conversation

Projects
None yet
2 participants
@ProTip
Copy link
Contributor

ProTip commented Feb 27, 2019

Set ui-trellis dependency to particular commit id

@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Mar 1, 2019

btw, i wonder if it should use a tag/commit instead of branch name ... the branch is likely to change over time

@ProTip

This comment has been minimized.

Copy link
Contributor Author

ProTip commented Mar 1, 2019

That makes a lot of sense for releases.

@ProTip

This comment has been minimized.

Copy link
Contributor Author

ProTip commented Mar 7, 2019

Fixes #4593

@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Mar 7, 2019

@ProTip even for non-release code, since ui-trellis can change outside of rundeck code, it makes sense to set the dependency to a particular tag/commit I think

@ProTip

This comment has been minimized.

Copy link
Contributor Author

ProTip commented Mar 7, 2019

@gschueler I was thinking for some reason it would be good to get updates on master but.. That does not make sense to me ATM. I've pinned the ui-trellis version.

@gschueler gschueler added this to the 3.0.17 milestone Mar 8, 2019

@gschueler gschueler merged commit b08f2a0 into master Mar 8, 2019

19 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.