Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new option features ( sort, list delimiter). #4599

Merged
merged 5 commits into from May 28, 2019

Conversation

@ltamaster
Copy link
Contributor

commented Mar 7, 2019

Is this a bugfix, or an enhancement? Please describe.
Fix for the following issues:
#1394
#4419
#4389

Describe the solution you've implemented

  • Adding a new option field in order to save the option list values as the user set it on the job (not as a list, but a string).
  • Also, a new toggle called sort list was added in order to sort the option list values. This allows users to preserve the order of the list in case the flag is false.
  • Finally, another field called list delimiter was added in order to specify the delimiter of the list

Additional context

New Sort field
screenshot 2019-03-07 14 37 51

screenshot 2019-03-07 14 38 09

Sort numeric list
screenshot 2019-03-07 14 38 32

screenshot 2019-03-07 14 39 11

New delimiter field

screenshot 2019-03-07 14 40 08

screenshot 2019-03-07 14 40 19

@gschueler gschueler added this to the 3.0.18 milestone Mar 14, 2019

@jessemarple jessemarple modified the milestones: 3.0.18, 3.0.19 Mar 21, 2019

@ProTip ProTip modified the milestones: 3.0.19, 3.0.20 Mar 27, 2019

ltamaster added some commits Mar 27, 2019

- not write to the values field anymore. Instead just return the conv…
…erted values as a List.

- When an Option/Job is created/updated, the values field should be set to null instead
- removing duplicate values
- moving placeholder message form option values list form to message.properties

@ltamaster ltamaster requested a review from gschueler Apr 4, 2019

@ProTip ProTip modified the milestones: 3.0.20, 3.0.21 Apr 8, 2019

@gschueler gschueler modified the milestones: 3.0.21, 3.1.0 Apr 19, 2019

gschueler added some commits May 9, 2019

@gschueler gschueler merged commit f2e2de1 into master May 28, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.