Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow option default value empty with default value declared in JSON (remote options) #2531 #4694

Merged
merged 4 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@carlosrfranco
Copy link
Contributor

commented Apr 8, 2019

With this changes, if a option get values from a remote JSON with a declared default value, so the options do not need to have a default value when it is a required option on scheduled execution

@gschueler
Copy link
Member

left a comment

The code to expandUrl, as well as to get the remote options JSON should not be duplicated from the ScheduledExecutionController.groovy. Perhaps migrate the code to a common utility class so it can be used in both locations

@carlosrfranco carlosrfranco requested a review from gschueler Apr 11, 2019

@gschueler
Copy link
Member

left a comment

Should also delete ScheduledExecutionController.expandUrl method since it has been moved

@carlosrfranco carlosrfranco requested a review from gschueler Apr 19, 2019

@gschueler gschueler merged commit 2ca81af into rundeck:master Apr 25, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@gschueler gschueler added this to the 3.0.22 milestone Apr 25, 2019

@gschueler

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

ref #2531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.