Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4703 node detail popup cannot be dismissed #4810

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
1 participant
@gschueler
Copy link
Member

commented May 9, 2019

  • add knockout dom disposal callback
  • constrain popup viewport to main-panel
  • add mousedown handler to close popup for event outside of popup
  • create unique id for interactive elements in referenced html content when copied to popup

Is this a bugfix, or an enhancement? Please describe.

Fix #4703

Fix #4703 node detail popup cannot be dismissed
* add knockout dom disposal callback
* constrain popup viewport to main-panel
* add mousedown handler to close popup for event outside of popup
* create unique id for interactive elements in referenced html content when copied to popup

@gschueler gschueler added this to the 3.0.22 milestone May 9, 2019

@gschueler gschueler merged commit 72c8f81 into master May 10, 2019

21 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@gschueler gschueler deleted the issue/4703 branch May 10, 2019

@gschueler

This comment has been minimized.

Copy link
Member Author

commented May 10, 2019

also in maint-3.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.