Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple jobs ids to scheduler/takeover endpoint #4955

Merged
merged 2 commits into from Jul 2, 2019

Conversation

@jtobard
Copy link
Contributor

commented Jun 14, 2019

Currently, the takeover endpoint allows specifying only one job id or leave it empty for every job.
With this enhancement, using API v31 or greater you can specify multiple job ids using the same endpoint.

ENDPOINT: /api/31/scheduler/takeover

application/json

{
	"server": {
    "all": true
  },
  "jobs":[
  	{
    "id": "15f66e9e-4034-4eb4-9fb7-4d4a739f691b"
	},
	{
    "id": "e4b6fdeb-85dd-4080-b723-1571ca3e1097"
	}
  ]
}

application/xml

<takeoverSchedule>
	<server all="true"/>
	<job id="15f66e9e-4034-4eb4-9fb7-4d4a739f691b"/>
	<job id="e4b6fdeb-85dd-4080-b723-1571ca3e1097"/>
</takeoverSchedule>

fix #4725

@jtobard jtobard marked this pull request as ready for review Jun 17, 2019

@jtobard jtobard requested a review from ltamaster Jun 20, 2019

@ltamaster
Copy link
Contributor

left a comment

LGTM

@jtobard jtobard added this to the 3.1.0-RC2 milestone Jul 2, 2019

@jtobard jtobard merged commit a5dc19a into master Jul 2, 2019

21 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@jtobard jtobard deleted the issue/4725 branch Jul 2, 2019

@jtobard

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

This need to be moved to api version 32

jtobard added a commit to rundeck/docs that referenced this pull request Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.