Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Rundeck profile from LDAP user attributes for official docker image #4995

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@ltamaster
Copy link
Contributor

commented Jun 26, 2019

Is this a bugfix, or an enhancement? Please describe.
enhancement: exposing sync Rundeck profile from LDAP user attributes for official docker image.

Describe the solution you've implemented
Adding the following environment variables:

  • RUNDECK_JAAS_LDAP_USERLASTNAMEATTRIBUTE
  • RUNDECK_JAAS_LDAP_USERFIRSTNAMEATTRIBUTE
  • RUNDECK_JAAS_LDAP_USEREMAILATTRIBUTE
  • RUNDECK_SECURITY_SYNCLDAPUSER

Describe alternatives you've considered

Additional context

Example:

Screenshot 2019-06-25 20 19 49

@ltamaster ltamaster requested a review from ProTip Jun 26, 2019

@@ -54,3 +54,7 @@ rundeck.feature.repository.enabled={{ getv("/rundeck/feature/repository/enabled"
{% set enabled = printf("/rundeck/features/%s/enabled", c) -%}
rundeck.features.{{ c }}.enabled={{ getv(enabled, "false") }}
{% endfor %}

{% if exists("/rundeck/security/syncldapuser") %}
rundeck.security.syncLdapUser={{ getv("/rundeck/security/syncldapuser") }}

This comment has been minimized.

Copy link
@ProTip

ProTip Jun 26, 2019

Contributor

This might be better group up with/after the other security settings?

@ProTip

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

LGTM pending one nit 😄

@ltamaster ltamaster requested a review from ProTip Jul 2, 2019

@ProTip

ProTip approved these changes Jul 3, 2019

@ltamaster ltamaster added this to the 3.1.0-RC2 milestone Jul 15, 2019

@gschueler gschueler merged commit 0c65649 into master Jul 16, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.