Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5000 highlight workflow editor unsaved changes issues #5014

Merged
merged 3 commits into from Jul 2, 2019

Conversation

@gschueler
Copy link
Member

commented Jun 30, 2019

Is this a bugfix, or an enhancement? Please describe.

Fixes #5000

Describe the solution you've implemented

When a job Option or workflow Step edit panel is open and the create/save button is clicked, this adds a warning indicator the the Workflow tab, adds warning text by the form submit button, and highlights the unsaved job Option or workflow Step section inside the workflow tab.

Screen Shot 2019-06-30 at 11 46 56 AM

Screen Shot 2019-06-30 at 11 47 06 AM

Screen Shot 2019-06-30 at 11 47 27 AM

@gschueler gschueler changed the title Rundeck 5000 Fix #5000 highlight workflow editor unsaved changes issues Jul 1, 2019

@gschueler gschueler requested a review from jessemarple Jul 2, 2019

@jessemarple
Copy link
Contributor

left a comment

Reviewed code and tested in App. Works perfectly.

@jessemarple jessemarple merged commit ba5a2c7 into master Jul 2, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@gschueler gschueler added this to the 3.1.0-RC2 milestone Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.