Adding attribute-match-node-enhancer plugin to the rundeck oss core #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This plugin can be used to solve an issue from support that causes the osFamily attribute do define the file extension to be dispatched to a node
gschueler
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rundeckpro/rundeckpro#607
Is this a bugfix, or an enhancement? Please describe.
When a node have the osFamily attribute with value "Windows", the job with an inline script step dispatch a .bat file even though this node needs to run a .sh file (using cygwin)
Describe the solution you've implemented
This plugin (https://github.com/rundeck-plugins/attribute-match-node-enhancer) can be used to solve this issue (https://github.com/rundeckpro/rundeckpro/issues/607) from support that causes the osFamily attribute do define the file extension to be dispatched to a node
Describe alternatives you've considered
I considered to use the advanced settings on script step the override the file extension default, however, this is not a friendly solution when it comes to several jobs since user would have to set them all individually.