Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding attribute-match-node-enhancer plugin to the rundeck oss core #5017

Merged
merged 2 commits into from Jul 18, 2019

Conversation

@carlosrfranco
Copy link
Contributor

commented Jul 1, 2019

fixes rundeckpro/rundeckpro#607

Is this a bugfix, or an enhancement? Please describe.
When a node have the osFamily attribute with value "Windows", the job with an inline script step dispatch a .bat file even though this node needs to run a .sh file (using cygwin)

Describe the solution you've implemented
This plugin (https://github.com/rundeck-plugins/attribute-match-node-enhancer) can be used to solve this issue (rundeckpro/rundeckpro#607) from support that causes the osFamily attribute do define the file extension to be dispatched to a node

Describe alternatives you've considered
I considered to use the advanced settings on script step the override the file extension default, however, this is not a friendly solution when it comes to several jobs since user would have to set them all individually.

carlosrfranco added some commits Jul 1, 2019

Adding attribute-match-node-enhancer plugin to the rundeck oss core. …
…This plugin can be used to solve an issue from support that causes the osFamily attribute do define the file extension to be dispatched to a node

@gschueler gschueler added this to the 3.1.0-RC2 milestone Jul 18, 2019

@gschueler gschueler merged commit 25b2eaf into rundeck:master Jul 18, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No new issues
Details
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.