Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oficial docke image: adding custom templates for repository feature. #5040

Merged
merged 2 commits into from Jul 16, 2019

Conversation

@ltamaster
Copy link
Contributor

commented Jul 8, 2019

Is this a bugfix, or an enhancement? Please describe.
enhancement:
adding custom templates for plugin repository feature. it will expose using env variable the option to define an external or local plugin repository (for example using the s3 like storage)

Describe the solution you've implemented
new remco templates to add data to artifact-repositories.yaml and rundeck-config.properties based on env variables.

Additional context
Example of new variables

Save artifacts and installed plugins to a Minio object store

version: '3'

services:
  rundeck1:
    hostname: rundeck1
    image: ${RUNDECK_IMAGE:-rundeck/rundeck:local}
    links:
      - minio
    tty: true
    environment:
      RUNDECK_GRAILS_URL: http://localhost:4444
      RUNDECK_FEATURE_REPOSITORY_ENABLE: "true"
      RUNDECK_FEATURE_REPOSITORY_SYNCONBOOTSTRAP: "true"
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_NAME: MinioTest
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_TYPE: object
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_PATH: /
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_BUCKET: artifacts
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_OBJECTSTOREURL: http://minio:9000
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_ACCESSKEY: ${STORAGE_ACCESS_KEY_ID}
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_SECRETKEY: ${STORAGE_SECRET_KEY}
      RUNDECK_REPOSITORY_PLUGINS_PROVIDER_1_NAME: MinioTest
      RUNDECK_REPOSITORY_PLUGINS_PROVIDER_1_TYPE: object
      RUNDECK_REPOSITORY_PLUGINS_PROVIDER_1_PATH: /
      RUNDECK_REPOSITORY_PLUGINS_PROVIDER_1_CONFIG_BUCKET: plugins
      RUNDECK_REPOSITORY_PLUGINS_PROVIDER_1_CONFIG_OBJECTSTOREURL: http://minio:9000
      RUNDECK_REPOSITORY_PLUGINS_PROVIDER_1_CONFIG_ACCESSKEY: ${STORAGE_ACCESS_KEY_ID}
      RUNDECK_REPOSITORY_PLUGINS_PROVIDER_1_CONFIG_SECRETKEY: ${STORAGE_SECRET_KEY}
    ports:
      - 4444:4440

using multiples privates artifacts

version: '3'

services:
  rundeck1:
    hostname: rundeck1
    image: ${RUNDECK_IMAGE:-rundeck/rundeck:local}
    links:
      - minio
    tty: true
    environment:
      RUNDECK_GRAILS_URL: http://localhost:4444
      RUNDECK_FEATURE_REPOSITORY_ENABLE: "true"
      RUNDECK_FEATURE_REPOSITORY_SYNCONBOOTSTRAP: "true"
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_NAME: MinioTest
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_TYPE: object
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_PATH: /
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_BUCKET: artifacts
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_OBJECTSTOREURL: http://minio:9000
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_ACCESSKEY: ${STORAGE_ACCESS_KEY_ID}
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_1_CONFIG_SECRETKEY: ${STORAGE_SECRET_KEY}
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_2_NAME: Local
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_2_TYPE: file
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_2_PATH: /repo
      RUNDECK_REPOSITORY_ARTIFACTS_PROVIDER_2_CONFIG_BASEDIR: /home/rundeck/repo
    ports:
      - 4444:4440
adding custom templates for repository feature. it will expose using …
…env variable the option to define an external or local plugin repository (for example using the s3 like storage)

@ltamaster ltamaster requested a review from sjrd218 Jul 8, 2019

@ltamaster ltamaster requested a review from sjrd218 Jul 9, 2019

@sjrd218

sjrd218 approved these changes Jul 9, 2019

Copy link
Contributor

left a comment

Looks good to me.

@ltamaster ltamaster added this to the 3.1.0-RC2 milestone Jul 15, 2019

@gschueler gschueler merged commit 38bb8c0 into master Jul 16, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.