Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4781 Options from URL not filled when job is scheduled #5041

Merged
merged 3 commits into from Jul 30, 2019

Conversation

@carlosrfranco
Copy link
Contributor

commented Jul 10, 2019

fixes #4781 changing the behaviour of scheduled job with option from URL

Is this a bugfix, or an enhancement? Please describe.
A scheduled job do not get any option values (or get the default value, if defined) when a job has an option from URL with selected values

Describe the solution you've implemented
This changes makes a scheduled job and a job manually executed to have the same behaviour for options with remote URL values, that is, the job will take a default value if defined, or the remote value from URL if default is not defined.

fix #4781 these changes make a scheduled execution or a execution man…
…ually executed to have the same behavior with options with remote URL values

@gschueler gschueler requested a review from sjrd218 Jul 18, 2019

@carlosrfranco carlosrfranco requested a review from gschueler Jul 19, 2019

@jtobard jtobard added this to the 3.1.0 milestone Jul 23, 2019

@gschueler gschueler merged commit fe4e50b into rundeck:master Jul 30, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.