Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1654 to make cleanup on records in Workflow, workflow_step and workflow_workflow_step when executions are deleted #5049

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@carlosrfranco
Copy link
Contributor

commented Jul 12, 2019

Inserting the relationship attribute "belongsTo" for workflow class, so that the workflow record is deleted when an execution is deleted

Is this a bugfix, or an enhancement? Please describe.
Records in Workflow, workflow_step and workflow_workflow_step do not get cleaned up when executions are deleted causing orphaned records to remain in the tables

Describe the solution you've implemented
inserting the relationship attribute "belongsTo" on Workflow class, so that the workflow record is deleted when an execution is deleted

Fixes #1654 inserting the relationship attribute "belongsTo" for work…
…flow class, so that the workflow record is deleted when an execution is deleted

@carlosrfranco carlosrfranco requested a review from gschueler Jul 12, 2019

Fixes #1654 also inserting the attribute "belongsTo" for workflow cla…
…ss to do relationship with ScheduleExecution

@gschueler gschueler added this to the 3.1.0-RC2 milestone Jul 17, 2019

@gschueler gschueler merged commit b4670ff into rundeck:master Jul 17, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.