Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution cleanup on a cluster #5058

Merged
merged 3 commits into from Jul 18, 2019

Conversation

@ltamaster
Copy link
Contributor

commented Jul 16, 2019

Is this a bugfix, or an enhancement? Please describe.
Enhancement:
On a cluster environment where the serverNodeUUID of the cluster members normally changed (on docker o kubernetes env), the execution cleanup process doesn't work as expected. The main reason is each cluster member will try to remove its own executions (filtering by serverNodeUUID).

Describe the solution you've implemented
1.- A new method to get the list of dead members is added. Each active node will have a different list of dead members in order to not get the same list of executions to delete.
2.- if that list is not empty, then the execution query will search for those uuids (plus the uuid of the server).
3.- the list of dead member can include the "null" option. In this case, it will remove execution with the serverNodeUUID on null (cover cases when rundeck has migrated from not cluster to cluster env).
4.- Some optimizations were added (eg, query just for the execution ID, etc)

Describe alternatives you've considered

Additional context

ltamaster added some commits Jul 15, 2019

@ltamaster ltamaster requested a review from gschueler Jul 16, 2019

@ltamaster ltamaster added this to the 3.1.0-RC2 milestone Jul 16, 2019

@ltamaster ltamaster requested a review from gschueler Jul 17, 2019

@gschueler gschueler merged commit 5d7bea5 into master Jul 18, 2019

17 of 20 checks passed

security/snyk - core/build.gradle (rundeck) 16 new vulnerable dependency paths
Details
security/snyk - rundeck-storage/build.gradle (rundeck) 10 new vulnerable dependency paths
Details
security/snyk - rundeckapp/build.gradle (rundeck) 1 new vulnerable dependency path
Details
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.