Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #4990 - Adds pagination of tokens on user profile #5062

Conversation

@ahormazabal
Copy link
Contributor

commented Jul 17, 2019

This PR adds pagination to the token section of the user profile page, in order to support a high amount of tokens.

The main changes on this PR are:

  • Added a gsp-based paginator which will appear when the amount of tokens exeeds 50.
  • Page limit can be configured using the rundeck.gui.user.profile.paginatetoken.max.per.page key.
  • Depending on the paging conditions and amount of tokens, tokens will be added/deleted either via ajax or by reloading the page.
  • Added a new pagination taglib in order to support gsp pagination using bootstrap markup.

For further details see #4990

Fixes issue #4831

@ahormazabal ahormazabal added this to the 3.0.24 milestone Jul 17, 2019

@ahormazabal ahormazabal self-assigned this Jul 17, 2019

@ahormazabal

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

The continuous-integration/travis-ci/push check fails because i accidentally pushed this commit to the maint-3.0.x branch, triggering this check.
As the commit was deleted from that branch and moved to this PR, the check fails because cant find the commit reference on maint-3.0.x.

@ahormazabal ahormazabal requested a review from sjrd218 Jul 17, 2019

@sjrd218

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Is there any way to fix it where Travis will run on this PR?

@ahormazabal ahormazabal force-pushed the ahormazabal:backports/userprofile-tokenpaging branch from 23d8229 to 55a1c0f Jul 17, 2019

@ahormazabal

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

finally got it by amending and force-pushing the last commit. Now it should pass OK.

@ahormazabal

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

moved to #5065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.