Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quartz.threadPool.threadCount parameter in Docker image #5091

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@aleroyer
Copy link
Contributor

commented Jul 26, 2019

Hi 馃憢

Is this a bugfix, or an enhancement? Please describe.
It is an enhancement in the official docker image by supporting the quartz thread count configuration parameter through an environment variable.

Describe the solution you've implemented
Added in remco templates the possibility to set RUNDECK_QUARTZ_THREADPOOL_THREADCOUNT in rundeck-config.properties to override the default limit of 10 threads.

Describe alternatives you've considered
N/A.

Additional context
This will allow users to extends the thread count easily if they are running rundeck inside container and/or in Kubernetes.

aleroyer added some commits Jul 26, 2019

@AWKIF

This comment has been minimized.

Copy link

commented Jul 26, 2019

+1

1 similar comment
@kelu27

This comment has been minimized.

Copy link

commented Jul 26, 2019

+1

@gschueler gschueler requested a review from ProTip Jul 29, 2019

@ProTip

ProTip approved these changes Jul 29, 2019

Copy link
Contributor

left a comment

Thanks!

@gschueler gschueler added this to the 3.1.0 milestone Jul 29, 2019

@gschueler gschueler merged commit bc5ac35 into rundeck:master Jul 29, 2019

20 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@aleroyer aleroyer deleted the aleroyer:quartz-docker-config branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.