Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade font awesome to 5.10.2. Fixes #4756 #5269

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@sjrd218
Copy link
Contributor

sjrd218 commented Sep 18, 2019

Alex needs his cats and rainbows.

@sjrd218 sjrd218 requested a review from jessemarple Sep 18, 2019
@sjrd218 sjrd218 added this to the 3.1.1 milestone Sep 18, 2019
@jessemarple

This comment has been minimized.

Copy link
Contributor

jessemarple commented Sep 18, 2019

Why can I not stop laughing about this one?

Copy link
Contributor

jessemarple left a comment

Reviewed and Approved.

Files were replaced and SCSS was updated.

No need to update the app.scss as it is pulling in files by the same name as the ones they replaced.

@jessemarple jessemarple merged commit 9924610 into master Sep 18, 2019
21 checks passed
21 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
@jessemarple jessemarple deleted the issue/4756 branch Sep 18, 2019
sjrd218 added a commit that referenced this pull request Oct 18, 2019
Upgrade font awesome to 5.10.2. Fixes #4756 (bp #5269)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.