Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with plugin select value with multiOption #5302

Merged
merged 3 commits into from Sep 27, 2019

Conversation

@sjrd218
Copy link
Contributor

commented Sep 26, 2019

Fixes #4109

Java plugins with a property that came from @SelectValues with multOption=true did not send their values to the server correctly. The server wasn't handling the value type correctly. That is now fixed too.

sjrd218 added 2 commits Oct 17, 2018
…ith the g:checkbox tag that

causes improper parameters to be sent to the form.
…om the ui and saved.
@sjrd218 sjrd218 requested a review from gschueler Sep 26, 2019
@sjrd218 sjrd218 added the v3.1.2 label Sep 26, 2019
@ProTip ProTip added this to the 3.1.2 milestone Sep 26, 2019
Copy link
Member

left a comment

What is an example of how the old code didn't work?

@sjrd218 sjrd218 requested a review from gschueler Sep 27, 2019
@gschueler gschueler merged commit d7ec7b0 into master Sep 27, 2019
21 checks passed
21 checks passed
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
@gschueler gschueler deleted the issue/4109 branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.