Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Update: Notifications editor #6438

Merged
merged 36 commits into from Sep 19, 2020
Merged

Conversation

gschueler
Copy link
Member

@gschueler gschueler commented Sep 9, 2020

Is this a bugfix, or an enhancement? Please describe.

Replace old form field mechanism with Vue components.

Describe the solution you've implemented

  • Vue UI to edit notifications
  • existing notification data is passed as json to the Vue (edit existing job)
  • Notification data is stored as json in a single form field
  • json data is inflated when constructing job definition
  • Adds two "dummy" plugins for the email/webhooks builtin notification types, allowing normal plugin UI generation to be driven by them
    • the email/webhook notification implementation still happens through the builtin code (todo: move this to plugins themselves)
  • added undo/redo feature

Additional context

Old form based method was very old, and hit a Jetty limit of 1000 form fields(!) in some recent enterprise tests.

Enable new Vue method using feature flag rundeck.feature.notificationsEditorVue.enabled=true

Todos

  • Refine UI design
  • Fix issue in Vue code: Ace editor not loading correctly for display/editing of plugin config properties
  • remove old form-based code completely (gsp views, backend parsing/validation)

@gschueler gschueler added this to the 3.3.4 milestone Sep 10, 2020
@gschueler gschueler marked this pull request as ready for review September 17, 2020 16:29
@gschueler gschueler merged commit fa11470 into main Sep 19, 2020
@gschueler gschueler deleted the enh/job-edit-notifications-vue branch September 19, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants