New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Update: Notifications editor #6438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scope defines what props to show. defaultScope defines default scope for unscoped properties. scope Project shows Project/ProjectOnly scoped properties scope Framework shows Framework/Project scoped properties scope Instance shows Instance/InstanceOnly scoped properties when scope is not set, all properties are shown
…amework props in validation
mishingo
approved these changes
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Replace old form field mechanism with Vue components.
Describe the solution you've implemented
Additional context
Old form based method was very old, and hit a Jetty limit of 1000 form fields(!) in some recent enterprise tests.
Enable new Vue method using feature flag
rundeck.feature.notificationsEditorVue.enabled=true
Todos