New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/927 parallel execution #929

Merged
merged 3 commits into from Nov 11, 2014

Conversation

Projects
None yet
3 participants
@mezbiderli

mezbiderli commented Sep 15, 2014

No description provided.

@ahonor ahonor referenced this pull request Sep 26, 2014

Closed

Parallel execution #927

@onejli

This comment has been minimized.

Show comment
Hide comment
@onejli

onejli Oct 30, 2014

Contributor

@ahonor @gschueler Are there any updates on getting this merged?

Contributor

onejli commented Oct 30, 2014

@ahonor @gschueler Are there any updates on getting this merged?

@gschueler gschueler added this to the 2.4.0 milestone Oct 31, 2014

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Oct 31, 2014

Member

hi @onejli we are scheduling this for 2.4.0.

I was able to try the pull request just now. I had to tweak some code to work against the latest code, but nothing major.

I noticed there are a few limitations in the feature: "TODO" comments indicate keepgoing=false is not yet supported.

Another issue i saw: Killing a job will abort the execution, but the job is still marked as successful. I think this is a simple fix tho.

I think we will merge this as an "incubator" feature, meaning it must be enabled via a configuration flag. Once some of issues are ironed out we can remove that requirement.

Member

gschueler commented Oct 31, 2014

hi @onejli we are scheduling this for 2.4.0.

I was able to try the pull request just now. I had to tweak some code to work against the latest code, but nothing major.

I noticed there are a few limitations in the feature: "TODO" comments indicate keepgoing=false is not yet supported.

Another issue i saw: Killing a job will abort the execution, but the job is still marked as successful. I think this is a simple fix tho.

I think we will merge this as an "incubator" feature, meaning it must be enabled via a configuration flag. Once some of issues are ironed out we can remove that requirement.

@onejli

This comment has been minimized.

Show comment
Hide comment
@onejli

onejli Oct 31, 2014

Contributor

@gschueler Awesome, thanks for the update! I don't think flagging this as an incubator feature will cause us any issues. Out of curiosity, when will 2.4.0 officially be cut?

@johnburbridge @mezbiderli It looks like there might be a few small fixes we should make after this is merged behind a feature flag.

Contributor

onejli commented Oct 31, 2014

@gschueler Awesome, thanks for the update! I don't think flagging this as an incubator feature will cause us any issues. Out of curiosity, when will 2.4.0 officially be cut?

@johnburbridge @mezbiderli It looks like there might be a few small fixes we should make after this is merged behind a feature flag.

@gschueler gschueler merged commit 1de54fd into rundeck:development Nov 11, 2014

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Nov 11, 2014

Member

merged to development branch.
this can be enabled with rundeck-config.properties entry:

feature.incubator.parallelWorkflowStrategy=true
Member

gschueler commented Nov 11, 2014

merged to development branch.
this can be enabled with rundeck-config.properties entry:

feature.incubator.parallelWorkflowStrategy=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment