New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XXE via Man-in-the-Middle in OSRSNewsService #6160

Closed
ProDigySML opened this Issue Oct 24, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ProDigySML
Copy link

ProDigySML commented Oct 24, 2018

The Issue

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Where the Issue Occurred:

Insecure XML parsers are used below:

Document document = DocumentBuilderFactory.newInstance()
.newDocumentBuilder()
.parse(in);

Communication over HTTP may allow an attacker to edit a server's response and perform XXE attacks. The HTTP URL is displayed below:

private static final HttpUrl RSS_URL = HttpUrl.parse("http://services.runescape.com/m=news/latest_news.rss?oldschool=true");

Remediation

Perform communications over HTTPS

@Adam-

This comment has been minimized.

Copy link
Member

Adam- commented Oct 24, 2018

This service is not offered over https.

@Adam- Adam- closed this Oct 24, 2018

@Adam- Adam- added the wontfix label Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment