XXE via Man-in-the-Middle in OSRSNewsService

[prodigysml]

The Issue

An XML External Entity attack is a type of attack against an application that parses XML input. This attack occurs when XML input containing a reference to an external entity is processed by a weakly configured XML parser. This attack may lead to the disclosure of confidential data, denial of service, server side request forgery, port scanning from the perspective of the machine where the parser is located, and other system impacts.

Where the Issue Occurred:

Insecure XML parsers are used below:

runelite/http-service/src/main/java/net/runelite/http/service/feed/osrsnews/OSRSNewsService.java

Lines 72 to 74 in 6310f26

	Document document = DocumentBuilderFactory.newInstance()
	.newDocumentBuilder()
	.parse(in);

Communication over HTTP may allow an attacker to edit a server's response and perform XXE attacks. The HTTP URL is displayed below:

runelite/http-service/src/main/java/net/runelite/http/service/feed/osrsnews/OSRSNewsService.java

Line 53 in 6310f26

private static final HttpUrl RSS_URL = HttpUrl.parse("http://services.runescape.com/m=news/latest_news.rss?oldschool=true");

Remediation

Perform communications over HTTPS

[Adam-]

This service is not offered over https.