Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Equipment Inspector plugin #3733

Open
wants to merge 9 commits into
base: master
from

Conversation

@sean-duffy
Copy link

commented Jun 10, 2018

This plugin adds a "Inspect Equipment" option to the right-click player menu which opens a side-panel displaying the equipment that player currently has equipped.

demo

I often find myself seeing some gear or some nice fashionscape and wondering what that player was wearing but I'm not able to find out because the player is afk or has public chat off. So I decided to create this plugin to address that issue.

I posted this in the Discord and received feedback that it could be potentially OP for PKing, particularly as it's possible to see item charges, durability for barrows armour etc. This could maybe be addressed by hiding charge/durability info or adding code to disable it in the wilderness. I'd be interested to hear other thoughts on this, as I myself am not a PKer so I'm not fully aware of how the plugin would be advantageous in those scenarios.

The plugin seems to work most of the time, but quite often it seems that players which are loaded and on screen are missing from the player cache and therefore the plugin is unable to get their equipment. Would be grateful if anyone could offer any guidance on this, not sure why this is happening. Fixed in f63143e.

The plugin is disabled by default to avoid cluttering the sidebar for players not using this plugin.

@sean-duffy sean-duffy force-pushed the sean-duffy:equipment-inspector branch to b003d1c Jun 16, 2018

@ShaunDreclin

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2018

Small nitpick but I would change "Inspect Equipment" to "Inspect", to match the length of other right click ops on players

@deathbeam

This comment has been minimized.

Copy link
Member

commented Sep 2, 2018

I dont think this plugin should be implemented, seems quite op for e.g scouts when pking.

@sean-duffy

This comment has been minimized.

@ShaunDreclin

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2018

Is it really that op though? It doesn't give you any info you cant get just by looking at the person. (As long as items with charges are all displayed as the fully charged version)

@deathbeam

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

Well sometimes you can't see stuff like dboots under void etc, happens with plethora of items. Also, opening the interface is marginally faster than trying to determine what is person wearing + risk just by looking at the person

@Unmoon

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2018

IMO this is fine and the pros outweigh the cons, especially since it doesn't count risk and can't show ring and arrow slot. Most of the time people have switches in the wilderness, anyway.

@deathbeam

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

Hmm maybe, its hard to evaluate. Either way, if we would decide to implement this imo it should be part of the hiscore plugin with just icons and names as tooltips probably.

@Unmoon

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2018

I would like to see the official equipment interface (or similar in-game interface) be used for this, to be honest. Sidebar feels like the wrong place for this.

@deathbeam

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

Ah right, yeah that would be even better

@Janzzze

This comment has been minimized.

Copy link

commented Sep 7, 2018

What if you could disable the feature in the wilderness and pvp worlds?
this would prevent using it to see boots under void, quickly easily determine someone's risk and scouting.
Checking if player is logged in to a pvp world should be doable, but no idea if you can check if other player is in the wilderness while localplayer is not to prevent it being abused from the other side of the ditch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.