Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default examine chat color to green #4621

Merged
merged 1 commit into from Jun 27, 2019

Conversation

Projects
None yet
4 participants
@ltvill
Copy link
Contributor

commented Aug 1, 2018

For better visibility.

@Nightfirecat

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2018

Can you get screenshots comparing the change to the current code on the various chat backgrounds?

@ltvill

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2018

Can’t do that right now, sorry. It’s worse on the transparent chatbox.

@abextm abextm added the enhancement label Aug 2, 2018

@ltvill

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2018

Before:

image

After:

image

@devLotto

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

It should only change the colors for the transparent backgrounds, green is hard to read on the opaque one:

image

Change default examine chat color to green
For better visibility

@devLotto devLotto force-pushed the ltvill:patch-4 branch from fd1d2ee to a2b83e1 Jun 13, 2019

@devLotto

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

I have updated your pull request.

@devLotto devLotto merged commit 1e112f9 into runelite:master Jun 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.