Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ba: use equipment ItemContainer instead of PlayerComposition #8772

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
None yet
3 participants
@devLotto
Copy link
Member

commented May 6, 2019

Makes equipment querying consistent across the client by changing the Barbarian Assault plugin to use the equipment ItemContainer instead of the local player's PlayerComposition.

@devLotto devLotto added the enhancement label May 6, 2019

@Kamielvf

This comment has been minimized.

Copy link
Member

commented May 6, 2019

This should probably use the item container change event now then?

@devLotto

This comment has been minimized.

Copy link
Member Author

commented May 6, 2019

@Kamielvf

The IN_GAME_BA var isn't set when the ItemContainerChanged event is received, so the code as it is wouldn't work in an event callback. I could remove that client.getVar(Varbits.IN_GAME_BA) == 0 check though. Maybe that is a decent solution, so we get the event in there atleast instead of polling the container.

ba: use equipment ItemContainer instead of PlayerComposition
Makes equipment querying consistent across the client by changing the Barbarian Assault plugin to use the equipment ItemContainer instead of the local player's PlayerComposition.

@devLotto devLotto force-pushed the devLotto:ba-use-itemcontainer branch to 3c48ee2 May 7, 2019

@devLotto

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

Updated to use the item container change event. Tested and works well. 😃

@Adam- Adam- merged commit 8dc05fd into runelite:master May 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.