Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis #8811

Merged
merged 3 commits into from May 14, 2019

Conversation

Projects
None yet
4 participants
@devLotto
Copy link
Member

commented May 12, 2019

Disabled by default, this plugin replaces emoticons with their corresponding emoji image in the chat, in line with what has been discussed in #1464. The triggers must be separated from other words in a chat line for them to be replaced, and the triggers are case sensitive so people with the plugin off see emoticons with the correct capitalization.

Emoji Trigger Emoji Trigger Emoji Trigger
๐Ÿ™‚ :) ๐Ÿ˜‚ =') ๐Ÿค  3:)
๐Ÿ˜Š ^_^ ๐Ÿ˜€ :D ๐Ÿ˜„ =D
๐Ÿ˜‰ ;) ๐Ÿ˜ X-P ๐Ÿ˜› :P
๐Ÿ˜‹ =P~ ๐Ÿค— >:D< ๐Ÿ˜ค :>
๐Ÿค” :โ€‘? ๐Ÿ˜• :/ ๐Ÿ˜ =|
๐Ÿ˜‘ :| ๐Ÿ˜’ :-| ๐Ÿ™ :(
โ˜น๏ธ =( ๐Ÿ˜ข :'( ๐Ÿ˜ญ :_(
๐Ÿ˜ณ :$ ๐Ÿค :-# ๐Ÿ˜ฃ >_<
๐Ÿ˜Ž 8-) ๐Ÿ˜‡ O:) ๐Ÿ˜ˆ >:)
๐Ÿ˜ก >:( ๐Ÿ˜ฏ :โ€‘O ๐Ÿ˜ฎ :O
๐Ÿ˜ฑ :-@ ๐Ÿ™ˆ X_X ๐Ÿ’ƒ \:D/
๐Ÿ‘Œ (Ok) ๐Ÿ‘ (Y) ๐Ÿ‘Ž (N)
โค <3 ๐Ÿ’” </3 ๐Ÿ’ค Zzz
๐ŸŸ <>< ๐Ÿ˜ธ :3 ๐Ÿถ =3
๐Ÿฆ€ V(;,;)V ๐Ÿด --E ๐Ÿณ --(o)
๐ŸŽ‰ @@@ ๐Ÿ’ฆ ;; ๐Ÿ‘€ O.O
๐Ÿ’ฉ ~@~

image

@devLotto devLotto referenced this pull request May 12, 2019

Closed

Emojis #1464

@devLotto devLotto force-pushed the devLotto:emojis branch from 6253eea to e5bc3ec May 12, 2019

@Adam- Adam- force-pushed the devLotto:emojis branch from 7c882c2 to e70d470 May 13, 2019

@deathbeam

This comment has been minimized.

Copy link
Member

commented May 14, 2019

What about adding o.o or O.O for ๐Ÿ‘€

@ShaunDreclin

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

;; for ๐Ÿ’ฆ would work too, it's usually paired with emotes like ^_^;;

Just need something for ๐Ÿ’ฉ haha

Being disabled by default seems a bit iffy though, a plugin like this isn't very useful if nobody else has it turned on. I think more people would want it enabled than not want it (not counting people who don't care either way)

@deathbeam

This comment has been minimized.

Copy link
Member

commented May 14, 2019

:swing: fits the ๐Ÿ’ฉ emoji perfectly, imo

@devLotto devLotto force-pushed the devLotto:emojis branch from e70d470 to 329cd33 May 14, 2019

client: add emoji plugin
Replaces various emoticons entered in public/friends/private chats with their corresponding emoji images.

Co-authored-by: Adam <Adam@sigterm.info>
Co-authored-by: Tomas Slusny <slusnucky@gmail.com>

@devLotto devLotto force-pushed the devLotto:emojis branch from 329cd33 to 64019ea May 14, 2019

@devLotto

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Added ๐Ÿ’ฆ, ๐Ÿ‘€ and ๐Ÿ’ฉ

@devLotto devLotto requested a review from deathbeam May 14, 2019

@devLotto

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

@ShaunDreclin Having the chat be replaced with emojis might be a bit overwhelming for a new user of the client if they don't like them. I think having the plugin disabled by default is fine, because people who want it will likely know about its existence and enable it themselves.

@Adam- Adam- merged commit ace6a61 into runelite:master May 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You canโ€™t perform that action at this time.