Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format config enums as "Config Option" by default #8816

Merged
merged 2 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@devLotto
Copy link
Member

commented May 12, 2019

Makes it so enum options that don't override toString already don't shout at you anymore.

For example, CONFIG becomes Config and CONFIG_OPTION becomes Config Option.

You can still override toString on the enums if you want the config option to display apostrophes for example.

Before:

image

After:

image

@devLotto devLotto force-pushed the devLotto:format-config-enums branch 2 times, most recently from 420411f to 3f4da12 May 12, 2019

@deathbeam

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Can you update this also for latest XP tracker config addition?

@devLotto devLotto force-pushed the devLotto:format-config-enums branch from 3f4da12 to 69d788d May 14, 2019

@devLotto

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

Updated

@deathbeam deathbeam merged commit 3e59f38 into runelite:master May 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Adam-

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I really don't think this is solving an actual problem, and is introducing additional complexity for no reason.

@deathbeam

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I dont think there was any problem in first place, this is basically just cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.