Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feed: make new blog posts more visible by opening panel on startup, icon badge #9231

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@devLotto
Copy link
Member

commented Jun 27, 2019

Closes #907

On client (plugin) startup, opens the news feed side panel if there is a new blog post that was posted after the previously recorded latest blog post timestamp. After the panel has been opened, the plugin regards that as having read all new posts, and does not open the panel again next startup unless there's a new blog post at that time.


Adds "NEW" in green to the titles of new blog posts. This persists until client (plugin) restart.

image


Also, if a new blog post is posted while the feed panel is closed, the navbar button icon will get a red circle badge:

image

Clicking the navbar button (which opens the feed) reverts the icon back to the normal one. The plugin regards clicking the button as having read all new posts. If the user never clicks the button, the panel will force open the next time the client is started, so that new blog posts cannot be missed. 馃檪

@devLotto devLotto force-pushed the devLotto:feed-show-new-blogposts branch from 1a96abd to ded8c27 Jun 27, 2019

@Adam-

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

We already have Instant support for the config manager, can that just be used?

@Adam- Adam- requested a review from abextm Jul 1, 2019

@devLotto devLotto force-pushed the devLotto:feed-show-new-blogposts branch from ded8c27 to bcaa27f Jul 2, 2019

@devLotto

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2019

Instant works, updated

@abextm

abextm approved these changes Jul 3, 2019

Copy link
Member

left a comment

I would like #9270 to be merged with this, so my window won't inaccessible on startup sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.