New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakage on element with id "exports" #136

Closed
jacksonp opened this Issue Jan 9, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jacksonp

jacksonp commented Jan 9, 2016

The id="exports" here:

<!DOCTYPE html>
<title>test</title>

<div id="exports"></div>

<script src="https://code.jquery.com/jquery-2.1.3.min.js"></script>
<script src="bower_components/jquery-typeahead/dist/jquery.typeahead.min.js"></script>

causes: ReferenceError: module is not defined.

@running-coder

This comment has been minimized.

Owner

running-coder commented Jan 12, 2016

good catch! there are some validation missing https://github.com/umdjs/umd/blob/master/templates/jqueryPlugin.js

@running-coder running-coder added the Bug label Jan 12, 2016

@running-coder running-coder added this to the 2.3.2 milestone Jan 12, 2016

running-coder pushed a commit that referenced this issue Jan 12, 2016

tom bertrand
Version 2.3.2
Feature
- #139 Added ``resultCountPerGroup`` parameter to ``onResult`` callback

Fixes
- #134 Fixed XSS vulnerability
- #136 Fixed UMD module definition

Note
- ``onSearch`` callback now gets triggered when a key is pressed (not only when query > options.minLength)

running-coder added a commit that referenced this issue Jan 14, 2016

Version 2.3.2
Feature
- #139 Added ``resultCountPerGroup`` parameter to ``onResult`` callback

Fixes
- #134 Fixed XSS vulnerability
- #136 Fixed UMD module definition

Note
- ``onSearch`` callback now gets triggered when a key is pressed (not only when query > options.minLength)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment