New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Mobiles #149

Closed
kujain opened this Issue Feb 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@kujain

kujain commented Feb 9, 2016

Wondering if there's any support for mobile actions. For example:

  1. Currently clicking outside the typeahead box hides the box. This is fine on desktop (mouse) but on mobile, this action happens even on tap and scroll page. It hides the box before the user has a chance to scroll through the entire list of suggestions. This works only if you scroll within the box but thats risky. If would be great if there's a way for the plugin to currently recognize tap-scroll, tap-drag etc. events. If not, can you suggest a workaround?
  2. An alternative view for mobiles. For mobiles, clicking in the field shows the system keyboard that takes up half the screen, making most of the typeahead box get hidden under the keyboard. This makes scrolling more important but that doesn't really work as per the point above.Perhaps a simpler single scrollable list could work?

Thanks!

@running-coder

This comment has been minimized.

Owner

running-coder commented Feb 9, 2016

Hey, mobile should be supported but not entirely tested. If you have time I'm open to PR or it will have to wait a lil

@running-coder running-coder added this to the 2.4.0 milestone Feb 11, 2016

@running-coder running-coder modified the milestones: 2.5.0, 2.4.0 Mar 26, 2016

@running-coder running-coder modified the milestones: 2.5.0, backlog Apr 4, 2016

running-coder pushed a commit that referenced this issue Apr 14, 2016

tom bertrand

@running-coder running-coder modified the milestones: 2.6.0, backlog Apr 14, 2016

@running-coder

This comment has been minimized.

Owner

running-coder commented Apr 14, 2016

Hey kujain the modifs are on develop branch, let me know if everything works correctly

running-coder added a commit that referenced this issue Apr 22, 2016

Version 2.6.0
*Breaking change*
- Update Typeahead source option: source.group.url.url has been replaced by source.group.ajax.url

Features
- #69, #179 Added groupTemplate option
- #183 Allow Typeahead to search for deep source object keys

Fixes
- #149 Support for Mobiles
- #181 IE8 incompatibility
- #182 Fixed double form submit when the "Enter" key is pressed & fixed JS error when searching for an undefined or numeric value
- #184 Invalid encoded characters on dynamic requests for `{{query}}`

Notes
- Reworked the source.group options, url has been replaced by ajax
- Removed the source.group.ignore option, use source.group.filter instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment