New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 incompatibility caused by fix #105 #181

Closed
gulima opened this Issue Apr 13, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@gulima

gulima commented Apr 13, 2016

In Internet Explorer 8, Object.defineProperty() can be used only on DOM objects [1].
Calling this method on an "generic" object literal (like the xhrObject) throws an error that says object does not support this action, and the code execution is halted.
That way, jquery-typeahead is not compatible (when we need AJAX requests, at least) with IE8.

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty

@gulima gulima changed the title from IE8 incompatibility cause by fix #105 to IE8 incompatibility caused by fix #105 Apr 13, 2016

@running-coder

This comment has been minimized.

Owner

running-coder commented Apr 13, 2016

thanks for raising the issue gulima, will take a look at possible alternatives

@running-coder running-coder added the Bug label Apr 13, 2016

@running-coder running-coder added this to the 2.6.0 milestone Apr 14, 2016

running-coder pushed a commit that referenced this issue Apr 14, 2016

running-coder pushed a commit that referenced this issue Apr 14, 2016

@running-coder

This comment has been minimized.

Owner

running-coder commented Apr 14, 2016

Should be good now, lmk if anything

running-coder added a commit that referenced this issue Apr 22, 2016

Version 2.6.0
*Breaking change*
- Update Typeahead source option: source.group.url.url has been replaced by source.group.ajax.url

Features
- #69, #179 Added groupTemplate option
- #183 Allow Typeahead to search for deep source object keys

Fixes
- #149 Support for Mobiles
- #181 IE8 incompatibility
- #182 Fixed double form submit when the "Enter" key is pressed & fixed JS error when searching for an undefined or numeric value
- #184 Invalid encoded characters on dynamic requests for `{{query}}`

Notes
- Reworked the source.group options, url has been replaced by ajax
- Removed the source.group.ignore option, use source.group.filter instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment