New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twice url encoding #189

Closed
ivan-ilinov opened this Issue Apr 26, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@ivan-ilinov

ivan-ilinov commented Apr 26, 2016

source: { suggestion: { ajax: { url: 'path/suggestions', data: { key: '{{query}}' } } } }

Example.
I type "иван" and send request to "path/suggestions?key=%25D0%25B8%25D0%25B2%25D0%25B0%25D0%25BD".
But correct encoding is "%D0%B8%D0%B2%D0%B0%D0%BD".

@nop33

This comment has been minimized.

nop33 commented Apr 29, 2016

Did you try using the built-in function encodeURIComponent?

@ivan-ilinov

This comment has been minimized.

ivan-ilinov commented Apr 29, 2016

I didnt try using any URL encode/decode function.

@running-coder running-coder added the Bug label May 2, 2016

@running-coder running-coder added this to the 2.6.1 milestone May 2, 2016

running-coder added a commit that referenced this issue May 2, 2016

@running-coder

This comment has been minimized.

Owner

running-coder commented May 2, 2016

Hey Ivan, thanks for flagging the issue, I was indeed adding an extra encoding not knowing that the ajax object / browser request was already handling this.

running-coder added a commit that referenced this issue May 3, 2016

Version 2.6.1
Fixes
- #189 Twice url encoding
- #190 Strange JS-code fragment in href attribute value in result list when using jQuery version below 1.10
- #192 Results remain open when clicking inside a second typeahead field
- #193 Clicking on a suggested option does not select it on IE11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment