New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Up / Down / Tab navigation to have only 1 "selected" item #326

Closed
dave7777 opened this Issue Mar 24, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@dave7777

dave7777 commented Mar 24, 2017

Up and Down arrows do not move the selected row. When I type full search string the search - hover mouse over the result row and start pressing up and down arrows the original row KEEPS HIGHLIGHTED. is this a bug or I changed something?:)

Image and video hosting by TinyPic

thanking you for your fabulous script!

@running-coder

This comment has been minimized.

Owner

running-coder commented Mar 24, 2017

hey dave, indeed that selectable item could be improved and programmed similat to google's search bar, good idea!

in Their case, the hover acts as a "select", in Typeahead's case it only acts as a hover but you still have that "select" using the arrows, that could be tweaked to remove confusion for the user

@dave7777

This comment has been minimized.

dave7777 commented Mar 24, 2017

yes - can you please help me remove the confusion from your otherwise awesome script?) the up and down arrows should take the highlighted row and move up and down - the original cursor highlighting can be turned off after that?

@dave7777

This comment has been minimized.

dave7777 commented Mar 24, 2017

I can send you the link to the webpage to your email at tomlebrute ?

@running-coder

This comment has been minimized.

Owner

running-coder commented Mar 24, 2017

I am able to replicate this issue, link would be useful for #325

@running-coder running-coder changed the title from Up and Down arrows do not move the selected row to Improve Up / Down / Tab navigation to have only 1 "selected" item Mar 24, 2017

@dave7777

This comment has been minimized.

dave7777 commented Mar 24, 2017

Love the way you renamed the subject) Adds more clarity.... when do you think this can be corrected? I will try to generate the link for 325 in a few moments.

running-coder added a commit that referenced this issue Mar 28, 2017

Feature #326 Improve Up / Down / Tab navigation to have only 1 "selec…
…ted" item

Changed callbacks to be user for mouse over or navigation `onEnter` and `onLeave`

@running-coder running-coder added this to the 2.9.0 milestone Mar 28, 2017

@running-coder

This comment has been minimized.

Owner

running-coder commented Mar 28, 2017

Should be good on develop branch

running-coder added a commit that referenced this issue Aug 18, 2017

Version 2.9.0
Feature
- #306 Allow Typeahead to be initialized on <textarea> and <div> with content editable

Fixes
- #363 `templateValue` option when navigating
- #360 Safari pressing Tab brings back to the first tabbable item
- #355 XSS issue with emptyTemplate when no results found
- #351 htmlEntities inside correlativeTemplate
- #311 When `href` option is set, pressing Enter should follow the link

Improvement
- #326 Improve Up / Down / Tab navigation to have only 1 "selected" item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment