New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Working in IE 10 or 11 #376

Closed
bdjema opened this Issue Sep 23, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@bdjema

bdjema commented Sep 23, 2017

Dear,
Thanks for this plugin, but it not working in IE 10 or IE 11, Not Error show in web console.

Thanks and Regards,
Bdjema

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 1, 2017

Hey @bdjema I only see a css problem on IE10 & 11, could it be possible that it's not working because of a combination of configuration? Could you provide me your configuration with test data?

@janderegg

This comment has been minimized.

janderegg commented Oct 4, 2017

I've also got the css issue with IE (Loupe icon is too height; also in the demos). Will this be fixed soon?
capto_capture 2017-10-04_05-16-42_pm

running-coder added a commit that referenced this issue Oct 4, 2017

@running-coder running-coder added the Bug label Oct 4, 2017

@running-coder running-coder added this to the 2.10.2 milestone Oct 4, 2017

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 4, 2017

How does the visual look now? I know it's not perfectly centered but this is as far as I could go without breaking the modern browsers. Feel free to open a PR and modify the code a bit if you feel like it needs more tweaking (keep in mind to validate all other browsers as well).

@bdjema Could you add more details / screenshots regarding your original issue?

@janderegg

This comment has been minimized.

janderegg commented Oct 5, 2017

looks great now!

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 8, 2017

Closing, haven't got any reply regarding the original issue

running-coder added a commit that referenced this issue Oct 9, 2017

Version 2.10.2
Fixes
- #376 CSS issue on ie10-11
- #381 search request being sent when an item is selected
- #380 result container stays open on choosing an entry when `dynamic: true`

Improvement
- `searchOnFocus` behaviour when an input is pre-filled and the Typeahead input is focused
@bdjema

This comment has been minimized.

bdjema commented Oct 18, 2017

Sory for my late reply, i just come back from my holyday.
I configure this use custom template:

$(".js-typeahead").typeahead({
  minLength: 3,
  maxItem: 20,
  order: "asc",
  dynamic: true,
  highlight: true,
  suggestion: true,
  hint: true,
  cancelButton: false,
  backdrop: {
    "background-color": "#fff"
  },
  template: function(query, item) {
    return '<div class="row">\
             <div class="col-md-12">\
              <h4>{{Name}}</h4>\
              <h5>Code: {{Code}}<span class="label label-warning pull-right">{{Price}}</span></h5>\
            </div>\
            </div>';
  },
  emptyTemplate: "no result for {{query}}",
  correlativeTemplate: true,
  source: {
    products: {
      ajax: function(query) {
        return {
          type: "POST",
          url: "/forms/getproduct",
          data: {
            code: "{{query}}"
          },
          callback: {
            done: function(data) {
              return data;
            }
          }
        };
      }
    }
  },
  callback: {
    onClick: function(node, a, item, event) {
      ///append to table here
    }
  }
});

No data appears when i typing something and not call to server using ajax (for IE 10 or 11 only)

Work in All Browser (not IE 10 or 11)
For info work in EDGE Browser

@running-coder running-coder reopened this Oct 18, 2017

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 18, 2017

Thanks for the precision @bdjema , I'll have a look shortly

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 20, 2017

Hey @bdjema I've just tested IE 10 & 11, works without any issue, I'm able to get results and the requests are sent. From your config it seems that you are missing the display config to tell Typeahead to search in which keys of your objects, ex: display: ['Name', 'Code']

ie10_typeahead2 10 4

@bdjema

This comment has been minimized.

bdjema commented Oct 20, 2017

Hi, Thanks for fast response, now it working, i update typeahead version to..and problem solved.

Thanks and best regards

@bdjema bdjema closed this Oct 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment