New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion box stays open on choosing an entry when using dynamic:true #380

Closed
benji opened this Issue Oct 5, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@benji

benji commented Oct 5, 2017

I am playing with the first demo example "Country v1": https://jsfiddle.net/qz7dfsku/

I am trying to have the suggestion box disappear when I select one of the choices.
It seems adding dynamic: true breaks it, if I set it to false then it works.

Any way to tweak that ?

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 8, 2017

Hey @benji thanks for reporting the issue. Indeed that's an unwanted behaviour because of an extra request being sent #381 when the item is selected, will patch that asap.

@running-coder running-coder added the Bug label Oct 8, 2017

@running-coder running-coder added this to the 2.10.2 milestone Oct 8, 2017

running-coder added a commit that referenced this issue Oct 9, 2017

Fix #381 search request being sent when an item is selected
Fix #380 result container stays open on choosing an entry when `dynamic: true`
Improve `searchOnFocus` behaviour when an input is pre-filled and the Typeahead input is focused
@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 9, 2017

Should be resolved now, I've also added a couple tests over this.

running-coder added a commit that referenced this issue Oct 9, 2017

Version 2.10.2
Fixes
- #376 CSS issue on ie10-11
- #381 search request being sent when an item is selected
- #380 result container stays open on choosing an entry when `dynamic: true`

Improvement
- `searchOnFocus` behaviour when an input is pre-filled and the Typeahead input is focused
@benji

This comment has been minimized.

benji commented Oct 9, 2017

Really appreciate the fast resolution, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment