New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search request being sent when an item is selected #381

Closed
ionesculiviucristian opened this Issue Oct 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ionesculiviucristian

ionesculiviucristian commented Oct 7, 2017

In v.2.10.1, if I search a partial word (for ex: 12A) and the I click on one of the results (ex. Emil Racoviță :: 12A (Brasov, Brasov)) then the input will be filled with the selected text (as expected) BUT a new search request will be sent with the input's new value.

Could be here: 8248c9a at line 2447.

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 8, 2017

hey @ionesculiviucristian, thanks for reporting the issue, indeed an extra request is sent but shouldn't. I'll apply a fix and add a couple tests around that asap.

@running-coder running-coder added the Bug label Oct 8, 2017

@running-coder running-coder added this to the 2.10.2 milestone Oct 8, 2017

@running-coder running-coder changed the title from Strange behaivour to Search request being sent when an item is selected Oct 9, 2017

running-coder added a commit that referenced this issue Oct 9, 2017

Fix #381 search request being sent when an item is selected
Fix #380 result container stays open on choosing an entry when `dynamic: true`
Improve `searchOnFocus` behaviour when an input is pre-filled and the Typeahead input is focused
@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 9, 2017

Should be resolved now, I've also added a couple tests over this.

running-coder added a commit that referenced this issue Oct 9, 2017

Version 2.10.2
Fixes
- #376 CSS issue on ie10-11
- #381 search request being sent when an item is selected
- #380 result container stays open on choosing an entry when `dynamic: true`

Improvement
- `searchOnFocus` behaviour when an input is pre-filled and the Typeahead input is focused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment