New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limitTemplate doesn't display unless emptyTemplate is defined #396

Closed
corsacca opened this Issue Nov 21, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@corsacca

corsacca commented Nov 21, 2017

It took me a while to get the limitTemplate option to work. The code from the example worked but mine didn't. The difference is that i didn't have the emptyTemplate option defined.
I don't know if this is a bug or just needs to be mentioned in the docs.

@tombertrand

This comment has been minimized.

Collaborator

tombertrand commented Nov 21, 2017

hey @corsacca you are right, the limitTemplate should be working without the emptyTemplate, that was a mistake 👍

@running-coder running-coder added the Bug label Nov 21, 2017

@running-coder running-coder added this to the 2.10.5 milestone Nov 21, 2017

running-coder added a commit that referenced this issue Nov 21, 2017

@running-coder

This comment has been minimized.

Owner

running-coder commented Nov 21, 2017

This commit on the develop branch should resolve the issue.

@corsacca

This comment has been minimized.

corsacca commented Nov 22, 2017

@running-coder Nice work! I tested the develop branch and the limitTemplate now works without having the emptyTemplate defined.

running-coder added a commit that referenced this issue Jul 19, 2018

Version 2.10.5
Features
- Feature #397 update data of a multiselect

Fixes
- Fix #389 Allow `onLayoutBuiltBefore` to return a custom template, wrap `<li>` inside other `<ul>` or `<div>`
- Fix #396 limitTemplate doesn't display unless emptyTemplate is defined
- Fix #408 Null values in query data causes a null value error.
- Fix #424 groupOrder array doesn't work when group is a string
- Fix #434 The item value in the onCancel function in undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment