New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resultContainer wont dismiss on blur #92

Closed
giorgoc opened this Issue Oct 18, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@giorgoc

giorgoc commented Oct 18, 2015

Plugin works perfectly no issues at all. My only issue is that the resultContainer wont dismiss on blur, when users use the tab to move to the next field. They have to click to the suggested option, thats the only way to get it dismissed.

Any syggestion how to resolve this?

Thanks!

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 20, 2015

Hey giorgoc,

I have not tested the "tab" key in a form context where there would be multiple input fields around and how it should behave. I'll take a look as soon as I have time.

Thanks!

@running-coder running-coder added the Bug label Oct 20, 2015

@giorgoc

This comment has been minimized.

giorgoc commented Oct 20, 2015

Great thanks! :)

On Tue, Oct 20, 2015 at 6:29 PM, Tom Bertrand notifications@github.com
wrote:

Hey giorgoc,

indeed I did not tested the "tab" key in a form context where there would
be multiple input fields around. I'll take a look as soon as I have time.

Thanks!


Reply to this email directly or view it on GitHub
#92 (comment)
.

@running-coder

This comment has been minimized.

Owner

running-coder commented Oct 21, 2015

I've added the tab keycode (9) to behave the same as Esc meaning that if there is results they will hide on the first keystroke and the second will behave as the browser would expect, in your case going to the next input.

running-coder added a commit that referenced this issue Oct 22, 2015

Version 2.1.3
Fixes #87 {{query}} on url does not get updated on the second search
Fixes #92 resultContainer wont dismiss on blur
Fixes #93 Sending xhr request are not cleared once completed
Fixes #94 onLayoutBuiltBefore & this.hintIndex ordering issue

Minor CSS compatibility issue w/ Bootstrap4
Replaced deprecated $Ajax.complete callback -> http://api.jquery.com/jquery.ajax/ for jQuery 3.0-alpha
Minor: Fixed CSS issue on dark background using hint option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment