New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMD wrapper #102

Merged
merged 1 commit into from Nov 5, 2015

Conversation

Projects
None yet
2 participants
@unindented
Contributor

unindented commented Nov 5, 2015

By adding an UMD wrapper, we'd be able to require jquery.typeahead from RequireJS, Browserify, Webpack, etc.

Add UMD wrapper
By adding an UMD wrapper, we'd be able to require `jquery.typeahead`
from RequireJS, Browserify, Webpack, etc.
@unindented

This comment has been minimized.

Contributor

unindented commented Nov 5, 2015

@running-coder Let me know what you think.

@running-coder

This comment has been minimized.

Owner

running-coder commented Nov 5, 2015

definitely down for that, thanks for the PR

running-coder added a commit that referenced this pull request Nov 5, 2015

@running-coder running-coder merged commit 1056d99 into running-coder:master Nov 5, 2015

@unindented

This comment has been minimized.

Contributor

unindented commented Nov 5, 2015

Don't want to pressure you, but how often do you release new versions so that this change appears in the dist folder?

@running-coder

This comment has been minimized.

Owner

running-coder commented Nov 6, 2015

2.2.0 is scheduled for tonight / tomorrow, I've also re-ran grunt in the master branch so you should have the code change atm in the dist folder of the master branch

@unindented

This comment has been minimized.

Contributor

unindented commented Nov 6, 2015

Awesome, thank you!

running-coder pushed a commit that referenced this pull request Nov 10, 2015

tom bertrand
Version 2.2.0
#76, #95 Added groupOrder option
#80 Option to use a function to resolve group label
#90 options.cache< now accepts "true", "localStorage" or "sessionStorage"
#102 Add UMD wrapper

Fixes
#101 Uncaught TypeError: this.xhr[i].abort is not a function
#103 Typo in dropdownCarret option, now dropdownCaret

running-coder pushed a commit that referenced this pull request Nov 10, 2015

tom bertrand
Version 2.2.0
#76, #95 Added groupOrder option
#80 Option to use a function to resolve group label
#90 options.cache< now accepts "true", "localStorage" or "sessionStorage"
#102 Add UMD wrapper

Fixes
#101 Uncaught TypeError: this.xhr[i].abort is not a function
#103 Typo in dropdownCarret option, now dropdownCaret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment