Skip to content

And simplification: substitute function applications for constructors #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 22, 2020
Merged

And simplification: substitute function applications for constructors #2147

merged 8 commits into from
Sep 22, 2020

Conversation

@ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Sep 16, 2020

Fixes #2095

Reviewer checklist
  • Test coverage: stack test --coverage
  • Public API documentation: stack haddock

@ana-pantilie ana-pantilie marked this pull request as ready for review September 16, 2020 12:07
@ana-pantilie
Copy link
Contributor Author

ana-pantilie commented Sep 16, 2020

@ttuegel I ran the test with and without these changes.

  • result is the resulting pattern on the latest kore master
  • resultNew is with the changes from this PR

results.zip

@ttuegel ttuegel mentioned this pull request Sep 16, 2020
Closed
@ttuegel ttuegel self-requested a review September 17, 2020 14:04
ttuegel
ttuegel approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some clean-up and approved. If my changes look good to you, then please add the integration test from the bug report in #2095 and merge.

@rv-jenkins rv-jenkins merged commit b1c34c5 into runtimeverification:master Sep 22, 2020
@ttuegel ttuegel mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ttuegel ttuegel ttuegel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refute side condition by transitivity of equality

3 participants

@ana-pantilie @ttuegel @rv-jenkins