Skip to content

Remove unused options from cterm_symbolic function#4789

Merged
ehildenb merged 2 commits into
developfrom
simplify-cterm-symbolic
Apr 7, 2025
Merged

Remove unused options from cterm_symbolic function#4789
ehildenb merged 2 commits into
developfrom
simplify-cterm-symbolic

Conversation

@ehildenb
Copy link
Copy Markdown
Member

@ehildenb ehildenb commented Apr 3, 2025

None of the downstream semantics use the maude_port functionality and extra dispatch functionality of the cterm_symbolic at this point, so it's removed.

We also remove a check that bug_report_id is set, because it's only used in one place, and in that spot we anyway handle the case where it's unset:

base_name = self._bug_report_id if self._bug_report_id is not None else 'kore_rpc'

@ehildenb ehildenb requested a review from gtrepta April 3, 2025 20:56
@ehildenb ehildenb self-assigned this Apr 3, 2025
Copy link
Copy Markdown
Contributor

@gtrepta gtrepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pyk/src/pyk/kore/rpc.py
@ehildenb ehildenb merged commit bdcb85a into develop Apr 7, 2025
@ehildenb ehildenb deleted the simplify-cterm-symbolic branch April 7, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants