Clean up nix code #664
Merged
Clean up nix code #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
approved these changes
Jun 28, 2024
Contributor
goodlyrottenapple
left a comment
goodlyrottenapple
left a comment
There was a problem hiding this comment.
LGTM. One thing we could also tighten up would be to make everything depend on the same rv_utils down the chain. Even though we point to the same rv_utils independently, in the flake lock, we have 4 copies. Having only one copy should prevent subtle bugs where once copy could potentially be different to the rest...
Contributor
Author
|
Ah, that's a good point. I'll follow up on that in the K toolchain repositories separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Pyk and K have aligned their respective versions of Nixpkgs, we can begin to clean up some of the Nix code that was previously required to work around them being separated.