CSV / FCSV issue #7

Open
wants to merge 1 commit into
from

Projects

None yet

4 participants

to_csv was tossing instance related issues, calling FCSV.instance instead of straight-up FCSV seems to have cured it.

@andersonbrandon andersonbrandon CSV formatter was calling FCSV(output, options.format_options || {}) …
…causing error

NoMethodError: undefined method `instance' for Ruport::Formatter::CSV:Class

Changed to FCSV.instance(output, options.format_options || {})
e6ae247
Collaborator
Odaeus commented Feb 28, 2011

Hi, thanks for the patch. Can you tell me which version of Ruby you tested it against?

ruby 1.9.2p136 (2010-12-25 revision 30365) [x86_64-darwin10.6.0] via RVM

Collaborator
Odaeus commented Jun 10, 2011

Sorry I didn't get around to applying this fix. I'm currently trying to get the test suite to run on Ruby 1.9.2. Since the FasterCSV library is now included as just CSV in the standard library I will try to remove the dependency based upon the version of Ruby the user has installed!

grosser commented Sep 4, 2013

any progress on that, still seeing stuff like this

Error:
#import_translations_from_csv#test_0003_detect missing placeholder in a translated string:
NotImplementedError: Please switch to Ruby 1.9's standard CSV library.  It's FasterCSV plus support for Ruby 1.9's m17n encoding engine.
    /Users/mgrosser/.rvm/gems/ruby-2.0.0-p247/gems/fastercsv-1.5.5/lib/faster_csv.rb:13:in `const_missing'
    /Users/mgrosser/.rvm/gems/ruby-2.0.0-p247/gems/fastercsv-1.5.5/lib/faster_csv.rb:19:in `method_missing'
    /Users/mgrosser/.rvm/gems/ruby-2.0.0-p247/gems/ruport-1.6.3/lib/ruport/data/table.rb:194:in `block in get_table_from_csv'
    /Users/mgrosser/.rvm/gems/ruby-2.0.0-p247/gems/ruport-1.6.3/lib/ruport/data/table.rb:292:in `initialize'
    /Users/mgrosser/.rvm/gems/ruby-2.0.0
Contributor
batter commented Jul 22, 2014

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment